-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carousels #573
Merged
Merged
Carousels #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffoodd
force-pushed
the
feature/pagination-dots
branch
2 times, most recently
from
November 23, 2020 09:19
4f9c82b
to
f39ade2
Compare
Closed
ffoodd
force-pushed
the
feature/pagination-dots
branch
2 times, most recently
from
December 15, 2020 16:15
3d830c0
to
5df6d34
Compare
ffoodd
force-pushed
the
feature/pagination-dots
branch
6 times, most recently
from
December 18, 2020 10:39
ef91b08
to
ecf2f53
Compare
Maybe something to improve progress indicator's animation: https://twitter.com/anatudor/status/1340051011323486209 |
Finally cannot be backported to v4 since we rely on |
…controls & indicators only class names
ffoodd
force-pushed
the
feature/pagination-dots
branch
from
January 5, 2021 10:16
37ff1af
to
f125767
Compare
Closed
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #550, closes #551
To-do
animation-duration
andanimation-play-state
(on:hover
).--carousel-interval
, and probably extend this to all boosted-only custom props — using a variable prefix?Get things done by adding pause button?(Carousel improvements #366).paused
should be added onmouseenter
, removed onmouseleave
.done
should be added when last slide anddata-bs-wrap="false"
--o-carousel-interval
should be set on indicator whendata-bs-interval
is provided.paused
/.done
classes?target-size()
mixin Somewhere?Should the animated progress indicator be a variant?data-bs-interval="false"
? Bootstrap #32640 commenttarget-size()
:44px
equivalent as default sizemin-content
and other keywords?Preview: https://deploy-preview-573--boosted.netlify.app/docs/5.0/components/carousel/ ("with indicators", "Individual .carousel-item interval", "Prevent cycling", "Static carousel")