Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(merge v4-dev): latest patched commit β†’ 8e59752ee #575

Merged
merged 4 commits into from
Dec 7, 2020

Conversation

ffoodd
Copy link
Contributor

@ffoodd ffoodd commented Nov 25, 2020

Fixes #574

Merging Bootstrap #32077 πŸš€

To-do / check

  • _data, _layout and _includes seems to have unmoved contents.
  • custom examples
  • RTL examples script, build/docs-rtl.js
  • Essentials
    • Use .tooltip-demo to trigger tooltips
  • Boostwatch:
    • Use .tooltip-demo to trigger tooltips
    • nav-boostwatch should be improved with a loop
  • Home: use masthead.html and masthead-followup.html partials
  • Custom pages (licence, Boosted history, etc.) in site/docs/4.5, should move to site/content/docs/4.5
  • moved _config.yml to a new grid.yml file in /data/: need to check where it was used
  • Liquid to Hugo:
    • {% if %} β†’ {{ if }}
    • {% endif %} β†’ {{ end }}
    • {{ site.baseurl }}/docs/{{ site.docs_version }}/…" β†’ {{< docsref "/…" >}}
    • Should anchors be outside shortcode?
    • redirect_from: β†’ aliases:
    • {{ site.docs_version }} β†’ {{< param docs_version >}}
    • {{ site.current_version }} β†’ {{< param current_version >}}
    • {{ site.bootstrap_current_version }} β†’ {{< param current_version >}}
    • {% capture example %} + {% endcapture %}
    • {% capture callout %}
    • {% include icons/placeholder.svg width="100%" height="250" class="" text="Image" %} β†’ {{< placeholder width="100%" height="250" class="" title="Image" >}}
    • {% for * in* %} + {% endfor %}
    • {% highlight * %} + {% endhighlight %}
    • [comment]: # Boosted mod: * … <!-- Boosted mod: * -->
    • [comment]: # End mod … <!-- End mod -->
    • {% just to be sure we didn't forget any Liquid related thing
  • check if some scripts / styles in partials layout can be added through extra_css and extra_js
    • added focus-visible polyfill when $include_js is false in examples / essentials layout
  • check if some essentials / custom examples can use include_js
  • use placeholder partial in custom examples / essentials / boostwatch if needed β†’ not required, if it works as-is
  • search for bootstrap and Bootstrap
  • Custom carousel's page: use config.yml entries for "Usage" example
  • check Tarteaucitron

To fix upstream

  • add SRI in partials/stylesheet.html for DocSearch (moght need to target 2.5.3 instead of 2)
  • add a config entry for CDN base URL, https://cdn.jsdelivr.net/npm/? β†’ Only 4 occurrencies upstream.
  • Navbar bottom example seems to have a link with href and role="button" (in the jumbotron)?
  • <table class="table text-left"> in layout/overview: text-left is useless β†’ (Bootstrap #32363)
  • Dropdown docs show custom checkboxes with v5 pattern: https://v4-dev--twbs-bootstrap.netlify.app/docs/4.5/components/dropdowns/#forms β†’ invalid

@ffoodd ffoodd added v4 dependencies Pull requests that update a dependency file chore docs Improvements or additions to documentation merge Sync with Bootstrap labels Nov 25, 2020
@ffoodd ffoodd added this to the 4.6.0 milestone Nov 25, 2020
@ffoodd ffoodd self-assigned this Nov 25, 2020
@ffoodd ffoodd force-pushed the chore/merge-v4-dev@8e59752ee branch 18 times, most recently from f0ec5c0 to 811c15b Compare December 2, 2020 16:19
@ffoodd ffoodd marked this pull request as ready for review December 2, 2020 16:24
@ffoodd ffoodd force-pushed the chore/merge-v4-dev@8e59752ee branch 3 times, most recently from 15c318c to 34fae71 Compare December 4, 2020 09:20
@ffoodd ffoodd force-pushed the chore/merge-v4-dev@8e59752ee branch 2 times, most recently from 2d78bcc to 359ffa9 Compare December 4, 2020 09:49
@ffoodd ffoodd force-pushed the chore/merge-v4-dev@8e59752ee branch 15 times, most recently from c53fa64 to 0b7833b Compare December 7, 2020 14:22
@ffoodd ffoodd force-pushed the chore/merge-v4-dev@8e59752ee branch from 0b7833b to 17ae20a Compare December 7, 2020 14:27
@ffoodd ffoodd merged commit b92e24f into v4-dev Dec 7, 2020
@ffoodd ffoodd deleted the chore/merge-v4-dev@8e59752ee branch December 7, 2020 15:07
@ffoodd ffoodd mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies Pull requests that update a dependency file docs Improvements or additions to documentation merge Sync with Bootstrap v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4 docs moving to Hugo
1 participant