Handle .container-fluid to follow brand
#987
Conversation
julien-deramond
changed the title
julien-deramond
requested review from
julien-deramond
and removed request for
julien-deramond
This comment was marked as outdated.
This comment was marked as outdated.
louismaximepiton
changed the title
.container-fluid to follow brand
|
Code review OK for me.
|
julien-deramond
force-pushed
the
main-lmp-supra-bars
branch
from
2e569c4
to
43ea4c8
Compare
Signed-off-by: louismaximepiton <louismaxime.piton@orange.com>
Signed-off-by: louismaximepiton <louismaxime.piton@orange.com>
Signed-off-by: louismaximepiton <louismaxime.piton@orange.com>
Signed-off-by: louismaximepiton <louismaxime.piton@orange.com>
Signed-off-by: louismaximepiton <louismaxime.piton@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
julien-deramond
force-pushed
the
main-lmp-supra-bars
branch
from
6eb5c46
to
b78a3ee
Compare
| margin-right: auto; | ||
| margin-left: auto; | ||
| } | ||
| {{< scss-docs name="container-mixins" file="scss/mixins/_container.scss" >}} |
There was a problem hiding this comment.
If their @mixin make-container example is supposed to be the same the code than in scss/mixins/_container.scss, then you could propose your modification to Bootstrap.
Because what's displayed here is different from https://github.com/twbs/bootstrap/blob/main/scss/mixins/_container.scss.
There was a problem hiding this comment.
From what I've seen, we can try this solution in order to be able to finish the Global Headers, Footers and Local Headers, and have the correct responsive behavior asked by the designers.
The use of .container-xxl everywhere seems to be a good solution for Orange websites to easily have this behavior.
Let's merge and see in few commits if it works while we provide examples for the developers in Boosted!
Previews:
Before merge :