Remove cloning on AST request helpers.

packages/hurl/src/runner/hurl_file.rs

@@ -396,7 +396,7 @@ fn run_request(
 fn get_output_source_info(entry: &Entry) -> SourceInfo {
     let mut source_info = entry.source_info();
     for option_entry in entry.request.options() {
-        if let OptionKind::Output(value) = option_entry.kind {
+        if let OptionKind::Output(value) = &option_entry.kind {
             source_info = value.source_info;
         }
     }

packages/hurl/src/runner/request.rs

@@ -61,7 +61,7 @@ pub fn eval_request(
 
     // Query string params
     let mut querystring = vec![];
-    for param in &request.querystring_params() {
+    for param in request.querystring_params() {
         let name = template::eval_template(&param.key, variables)?;
         let value = template::eval_template(&param.value, variables)?;
         let param = http::Param { name, value };
@@ -70,7 +70,7 @@ pub fn eval_request(
 
     // Form params
     let mut form = vec![];
-    for param in &request.form_params() {
+    for param in request.form_params() {
         let name = template::eval_template(&param.key, variables)?;
         let value = template::eval_template(&param.value, variables)?;
         let param = http::Param { name, value };
@@ -79,7 +79,7 @@ pub fn eval_request(
 
     // Cookies
     let mut cookies = vec![];
-    for cookie in &request.cookies() {
+    for cookie in request.cookies() {
         let name = template::eval_template(&cookie.name, variables)?;
         let value = template::eval_template(&cookie.value, variables)?;
         let cookie = http::RequestCookie { name, value };
@@ -92,7 +92,7 @@ pub fn eval_request(
     };
 
     let mut multipart = vec![];
-    for multipart_param in &request.multipart_form_data() {
+    for multipart_param in request.multipart_form_data() {
         let param = multipart::eval_multipart_param(multipart_param, variables, context_dir)?;
         multipart.push(param);
     }

packages/hurl_core/src/ast/core.rs

@@ -56,56 +56,74 @@ pub struct Request {
 }
 
 impl Request {
-    pub fn querystring_params(&self) -> Vec<KeyValue> {
+    /// Returns the query strings params for this request.
+    ///
+    /// See <https://developer.mozilla.org/en-US/docs/Web/API/URL/searchParams>.
+    pub fn querystring_params(&self) -> &[KeyValue] {
         for section in &self.sections {
             if let SectionValue::QueryParams(params, _) = &section.value {
-                return params.clone();
+                return params;
             }
         }
-        vec![]
+        &[]
     }
-    pub fn form_params(&self) -> Vec<KeyValue> {
+
+    /// Returns the form params for this request.
+    ///
+    /// See <https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/POST#url-encoded_form_submission>.
+    pub fn form_params(&self) -> &[KeyValue] {
         for section in &self.sections {
             if let SectionValue::FormParams(params, _) = &section.value {
-                return params.clone();
+                return params;
             }
         }
-        vec![]
+        &[]
     }
-    pub fn multipart_form_data(&self) -> Vec<MultipartParam> {
+
+    /// Returns the multipart form data for this request.
+    ///
+    /// See <https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/POST#multipart_form_submission>.
+    pub fn multipart_form_data(&self) -> &[MultipartParam] {
         for section in &self.sections {
             if let SectionValue::MultipartFormData(params, _) = &section.value {
-                return params.clone();
+                return params;
             }
         }
-        vec![]
+        &[]
     }
 
-    pub fn cookies(&self) -> Vec<Cookie> {
+    /// Returns the list of cookies on this request.
+    ///
+    /// See <https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cookie>.
+    pub fn cookies(&self) -> &[Cookie] {
         for section in &self.sections {
             if let SectionValue::Cookies(cookies) = &section.value {
-                return cookies.clone();
+                return cookies;
             }
         }
-        vec![]
+        &[]
     }
 
-    pub fn basic_auth(&self) -> Option<KeyValue> {
+    /// Returns the basic authentication on this request.
+    ///
+    /// See <https://developer.mozilla.org/en-US/docs/Web/HTTP/Authentication>.
+    pub fn basic_auth(&self) -> Option<&KeyValue> {
         for section in &self.sections {
             if let SectionValue::BasicAuth(kv) = &section.value {
-                return kv.clone();
+                return kv.as_ref();
             }
         }
         None
     }
 
-    pub fn options(&self) -> Vec<EntryOption> {
+    /// Returns the options specific for this request.
+    pub fn options(&self) -> &[EntryOption] {
         for section in &self.sections {
             if let SectionValue::Options(options) = &section.value {
-                return options.clone();
+                return options;
             }
         }
-        vec![]
+        &[]
     }
 }