Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variables update #1046

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Fix variables update #1046

merged 2 commits into from
Dec 1, 2022

Conversation

jcamiel
Copy link
Collaborator

@jcamiel jcamiel commented Dec 1, 2022

Update variables hash while iterating and evaluating the capture section (instead of updating it once with all the variables).

Fixes #1037.

@jcamiel jcamiel force-pushed the features/fix-variables-update branch from bdb565c to 45050a4 Compare December 1, 2022 14:32
@jcamiel jcamiel marked this pull request as ready for review December 1, 2022 14:52
@fabricereix
Copy link
Collaborator

/accept

@hurl-bot
Copy link
Collaborator

hurl-bot commented Dec 1, 2022

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

hurl-bot commented Dec 1, 2022

✅ Pull request accepted and closed by fabricereix with fast forward merge..

# List of commits merged from Orange-OpenSource/hurl/features/fix-variables-update branch into Orange-OpenSource/hurl/master branch:

  • 45050a4 Update integration tests.
  • 51b196e Update variables hash while iterating and evaluating the capture section (instead of updating it once with all the variables).

@github-actions github-actions bot merged commit 45050a4 into master Dec 1, 2022
@github-actions github-actions bot deleted the features/fix-variables-update branch December 1, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable capture not working
3 participants