Fix cargo test --doc on Alpine #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcamiel
force-pushed
the
1124-cargo-test-doc-failed-on-alpine-distribution
branch
from
eb32ca1 to
5b015da
Compare
jcamiel
force-pushed
the
1124-cargo-test-doc-failed-on-alpine-distribution
branch
6 times, most recently
from
4cfc7a9 to
ae93191
Compare
jcamiel
force-pushed
the
1124-cargo-test-doc-failed-on-alpine-distribution
branch
from
ae93191 to
1809da5
Compare
jcamiel
force-pushed
the
1124-cargo-test-doc-failed-on-alpine-distribution
branch
from
1809da5 to
c11c5ed
Compare
|
/accept |
|
🕗 /accept is running, please wait for completion. |
|
✅ Pull request accepted and closed by
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
.cargo/config.tomlto pass the flag-Ctarget-feature=-crt-static(before we set this flag through env variables).By setting this flag in cargo config file,
cargo test --docis working now on Alpine. Plus, if we checkout the repo on Alpine and justcargo build, the binary produced is valid (instead of having to setRUSTFLAGS=-Ctarget-feature=-crt-staticbefore building).