Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated option append #263

Merged
merged 2 commits into from
Sep 25, 2021
Merged

Remove deprecated option append #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6908370
Remove deprecated option --append
fabricereix Sep 25, 2021
73cdd84
Update doc
fabricereix Sep 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,6 @@ Options that exist in curl have exactly the same semantic.

Option | Description
--- | ---
`--append` | This option can only be used with `--json`. It appends sessions to existing file instead of overwriting it. This is typically used in a CI pipeline.
`--color` | Colorize Output
`-b, --cookie <file>` | Read cookies from file (using the Netscape cookie file format). Combined with `-c, --cookie-jar`, you can simulate a cookie storage between successive Hurl runs.
`--compressed` | Request a compressed response using one of the algorithms br, gzip, deflate and automatically decompress the content.
Expand All @@ -478,10 +477,11 @@ Option | Description
`--fail-at-end` | Continue executing requests to the end of the Hurl file even when an assert error occurs. By default, Hurl exits after an assert error in the HTTP response. Note that this option does not affect the behavior with multiple input Hurl files. All the input files are executed independently. The result of one file does not affect the execution of the other Hurl files.
`--file-root <dir>` | Set root filesystem to import files in Hurl. This is used for both files in multipart form data and request body. When this is not explicitly defined, the files are relative to the current directory in which Hurl is running.
`-h, --help` | Usage help. This lists all current command line options with a short description.
`--html <dir>` | Generate html report in dir. If you want to combine results from different Hurl executions in a unique html report, you must also use the options `--json` and `--append`.
`--html <dir>` | Generate html report in dir. If the html report already exists, it will be updated with the new test results.
`-i, --include` | Include the HTTP headers in the output (last entry).
`--interactive` | Stop between requests. This is similar to a break point, You can then continue (Press C) or quit (Press Q).
`--json <file>`| Write full session(s) to a json file. The format is very closed to HAR format.By default, this file is overwritten by the current run execution. In order to append sessions to an existing json file, the option `--append` must be used. This is typically used in a CI pipeline.
`--json <file>`| Write full session(s) to a json file. The format is very closed to HAR format. If the json file already exists, the file will be updated with the new test results.

`--k, --insecure` | This option explicitly allows Hurl to perform "insecure" SSL connections and transfers.
`-L, --location` | Follow redirect. You can limit the amount of redirects to follow by using the `--max-redirs` option.
`-m, --max-time <seconds>` | Maximum time in seconds that you allow a request/response to take. This is the standard timeout. See also `--connect-timeout` option.
Expand Down
14 changes: 2 additions & 12 deletions docs/hurl.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,6 @@ Thanks to asserts, Hurl can be used as a testing tool to run scenarii.
Options that exist in curl have exactly the same semantic.


### --append {#append}

This option can only be used with [--json](#json). It appends sessions to existing file instead of overwriting it.
This is typically used in a CI pipeline.


### --color {#color}

Colorize Output
Expand Down Expand Up @@ -186,8 +180,7 @@ Usage help. This lists all current command line options with a short description

Generate html report in dir.

If you want to combine results from different Hurl executions in a unique html report, you must also use the options [--json](#json) and [--append](#append).

If the html report already exists, it will be updated with the new test results.


### -i, --include {#include}
Expand All @@ -205,10 +198,7 @@ This is similar to a break point, You can then continue (Press C) or quit (Press

Write full session(s) to a json file. The format is very closed to HAR format.

By default, this file is overwritten by the current run execution.
In order to append sessions to an existing json file, the option [--append](#append) must be used.
This is typically used in a CI pipeline.

If the json file already exists, the file will be updated with the new test results.


### -k, --insecure {#insecure}
Expand Down
11 changes: 0 additions & 11 deletions packages/hurl/src/cli/options.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,6 @@ pub fn app() -> clap::App<'static, 'static> {
.required(false)
.multiple(true),
)
.arg(
clap::Arg::with_name("append")
.long("append")
.help("Append sessions to json output"),
)
.arg(
clap::Arg::with_name("color")
.long("color")
Expand Down Expand Up @@ -344,12 +339,6 @@ pub fn parse_options(matches: ArgMatches) -> Result<CliOptions, CliError> {
let variables = variables(matches.clone())?;
let verbose = matches.is_present("verbose") || matches.is_present("interactive");

// deprecated
if matches.is_present("append") {
eprintln!("The option --append is deprecated. Results are automatically appended to existing report.");
eprintln!("It will be removed in the next version");
}

Ok(CliOptions {
color,
compressed,
Expand Down