Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build and test on docs/installation.md and CONTRIBUTING.md #3284

Closed
wants to merge 1 commit into from

Conversation

lepapareil
Copy link
Collaborator

@lepapareil lepapareil commented Oct 4, 2024

@jcamiel
Copy link
Collaborator

jcamiel commented Oct 4, 2024

Hi @lepapareil

Not fan of the changes: we should really emphasize that Hurl is a "classic" Rust project and, as expected, build is straightforward:

  • git clone ...
  • cargo build

And that's all: cargo build to build, cargo test to unit test, cargo fmt to format and cargo clippy to lint. These are expected and well known commands to Rust developers, that works on every OS.

On the order, I would keep unit tests first then integration tests: the former don't need a live server and you can cargo test --lib just after cloning the repo without any Python stuff. The latter is more complicated and could just be run in the CI/CD.

Maybe we can add a last section to indicate that we have standalone scripts for each test if developers prefer: 'bin/build/test-unit.sh` for unit test etc... BTW, I don't remember if the build script is in debug or release but release build are way slower than debug build.

@lepapareil
Copy link
Collaborator Author

Got it

@lepapareil lepapareil closed this Oct 4, 2024
@lepapareil lepapareil deleted the Fix/contrib-build-and-test branch October 4, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants