-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change TemplateElement
's source
field type from String
to SourceString
#3677
Change TemplateElement
's source
field type from String
to SourceString
#3677
Conversation
7e0f878
to
508deb2
Compare
/rebase |
🕗 /rebase is running, please wait for completion. |
508deb2
to
5428dec
Compare
5428dec
to
c58bf74
Compare
/accept |
🕗 /accept is running, please wait for completion. |
🔨 Auto rebase from |
🕗 /accept is still running, please wait for completion. |
c58bf74
to
3f3f9e9
Compare
✅ Pull request merged with fast forward by
|
This PR change
TemplateElement
'ssource
field type fromString
toSourceString
A newtype new struct
SourceString
is introduced incore::typing
and the methods to seamlessly work withString
&str
etc...Note
Not sure if
typing
is the best module name (it's model on Python). This module contains "common" types for Hurl's crates. Maybe we should change it fromtyping
totypes
?Rest of the code is updating unit tests.