Pass client_options in execute and executes_with_redirect HTTP client methods #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcamiel
force-pushed
the
feature/add-options-in-http-client-methods
branch
from
4403ea9 to
33ed1f4
Compare
|
/accept |
|
✅ Pull request accepted and closed by
|
github-actions
bot
deleted the
feature/add-options-in-http-client-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preliminary PR for #624 .
ClientOptionsis not saved anymore inClientstruct. We pass now anoption: &ClientOptionsparameter in each method of the HTTP client. This will make easier to override aClientOptionfor each executed request.