Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SREM / SSEM and DSRC library JSON Schemas #202

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

mathieu1fb
Copy link
Collaborator

@mathieu1fb mathieu1fb commented Nov 7, 2024

What's new;

JSON Schemas:
Added SREM and SSEM schemas, alongside a DSRC schema regrouping common definitions for both SREM and SSEM (to be completed for future needs).

closes #184 and closes #183


What to do:

  1. Read the new schemas and check them against ETSI repository docs for potential mistakes.
  2. Evaluate and discuss the impact of the use of new DSRC "units" before merging.

@mathieu1fb mathieu1fb added enhancement New feature or request Schema JSON schema files labels Nov 7, 2024
@mathieu1fb mathieu1fb added this to the Sprint 4 milestone Nov 7, 2024
@mathieu1fb mathieu1fb self-assigned this Nov 7, 2024
@Hugues360
Copy link
Collaborator

In another issue on mobility messages ( #137) it was asked to create directories for each message. Perhaps you can put each message in a directory (and that will test relative link to dsrc?)
Nota: in the PR linked to the same issue, I have change the "type" field of the header in "message_type". If it is approved, it should be the case for this messages too (can be done also in a 2.0.O version?)

schema/srem_schema_1-0-0.json Outdated Show resolved Hide resolved
schema/dsrc_schema_1-0-0.json Outdated Show resolved Hide resolved
schema/srem_schema_1-0-0.json Outdated Show resolved Hide resolved
schema/ssem_schema_1-0-0.json Outdated Show resolved Hide resolved
@ymorin-orange
Copy link
Member

In another issue on mobility messages ( #137) it was asked to create directories for each message. Perhaps you can put each message in a directory (and that will test relative link to dsrc?)

Nota: in the PR linked to the same issue, I have change the "type" field of the header in "message_type". If it is approved, it should be the case for this messages too (can be done also in a 2.0.O version?)

I think we should decide now what we do, either one of:

  • we merge the SREM/SSEM schemas first, so thus they should conform to the current practices and the PR doing the renaming and version bump should be rebased and would have to also update the SREM/SSEM schemans, or
  • we merge the renaming and version bump first, so thus the SREM/SSEM schemas should conform to the new practices.

The second option sounds more appealing to me, but this means the new practices must be properly documented so as to simplify those new schemas.

Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
@ymorin-orange
Copy link
Member

I think we should decide now what we do, either one of:
* we merge the SREM/SSEM schemas first [...]
* we merge the renaming and version bump first [...]

We decided for the first option: merge SREM/SSEM schemas first.

@mathieu1fb mathieu1fb merged commit 906d966 into Orange-OpenSource:master Nov 19, 2024
39 checks passed
@mathieu1fb mathieu1fb deleted the json-schema branch November 19, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Schema JSON schema files
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Define SREM contract Define SSEM contract
3 participants