-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust authority bootstrap #205
base: master
Are you sure you want to change the base?
Rust authority bootstrap #205
Conversation
20cb68b
to
0b56377
Compare
0b56377
to
24426bb
Compare
Why not include the example of copycat with bootstrap to the current PR (with another name to keep existing copycat)? As bootstrap is now a feature of the lib. |
#host="mydomain.com" | ||
#port="8080" | ||
#path="/bootstrap" | ||
#role="external-app" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no line for station_id in the example bootstrap section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is present in the [station]
section with the id
I agree that it might not be very intuitive at first sight, but this is a field that was already present and used so I thought I would be more relevant to use it instead of duplicating it in the [bootstrap]
section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But in your code there is in bootstrap_configuration.rs
station_id: get_mandatory_field::("station_id", section)?,
And so for bootstrapping, it is the station_id field in the [bootstrap] section that is taken (and that is mandatory) and not the id field of the [station] section, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, my bad, it takes is from the [bootstrap]
section, as indicated in the configuration example docstring
I remember having an issue about it, I'll fix it and push a new version
Problem is that it requires a running bootstrap server and for now the code is private and the platform is not deployed as publicly usable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See answer in the thread for station_id field in [bootstrap] section
Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
24426bb
to
2af51f4
Compare
Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
2af51f4
to
9fe0273
Compare
Changes are pushed, station_id now correctly comes from the |
What's new
New function to create a Configuration from bootstrap sequence
The bootstrap sequence provide services' URL and credentials, any of these information already present in the configuration file
All the other fields that are unrelated to services connection are still read from the configuration file and set in the Configuration object
closes #185
closes #161
How to test
examples/config.ini
and[bootstrap]
section with the proper endpoint and credentials[mqtt]
sectioncopycat
example using the bootstrap sequencecopycat
example