Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: update geo crate to 0.26 #86

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

nbuffon
Copy link
Member

@nbuffon nbuffon commented Aug 4, 2023

New features

  • rust: bump geo dependency to version 0.26
  • workflow: add Rust release build in checks

How to test

  1. Build in release mode

    cargo clean
    cargo build --release
    
  2. Run the CopyCat example in release mode

    cargo run --release --bin its-client -- -H <broker_host> -P <broker_port> -u <username> -p <password> --mqtt-client-id <client_id>
    

    => stdout logs tells that the copycat receives messages (cam, denm, ...)

  3. Check the applicative logs

    tail -F log/its-client_rCURRENT.log
    

    => Logs must tell about either copy/retain moving vehicle messages or stopped vehicle that are not copied

@nbuffon nbuffon self-assigned this Aug 7, 2023
@nbuffon nbuffon added Rust Rust code dependencies Pull requests that update a dependency file labels Aug 7, 2023
@ymorin-orange
Copy link
Member

@nbuffon In addition to the rust issue, could you add the reference to
the corresponding geo crate issue as well: georust/geo#1010

Previously used version 0.23 was carrying a [recursive declaration issue][1]
Fixed since geo 0.25 as mentioned in [related issue][2]

[1]: rust-lang/rust#110475
[2]: georust/geo#1010

Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
Closure recursive declaration issue was only happening in release build
Could have been detected before if release build was done here

Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
@nbuffon
Copy link
Member Author

nbuffon commented Aug 8, 2023

@nbuffon In addition to the rust issue, could you add the reference to the corresponding geo crate issue as well: georust/geo#1010

Done in corresponding commit's message

@nbuffon nbuffon merged commit 36072ad into Orange-OpenSource:master Aug 8, 2023
29 checks passed
@nbuffon nbuffon deleted the update_geo_crate branch November 23, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Rust Rust code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants