-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust mobility module #95
Merged
nbuffon
merged 9 commits into
Orange-OpenSource:2.0.0
from
nbuffon:rust_mobility_module
Jan 18, 2024
Merged
Rust mobility module #95
nbuffon
merged 9 commits into
Orange-OpenSource:2.0.0
from
nbuffon:rust_mobility_module
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbuffon
force-pushed
the
rust_mobility_module
branch
from
November 23, 2023 14:21
d4e3963
to
2c09940
Compare
nbuffon
added
documentation
Improvements or additions to documentation
Rust
Rust code
labels
Nov 23, 2023
Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
nbuffon
force-pushed
the
rust_mobility_module
branch
from
December 1, 2023 15:12
5573e56
to
5d80933
Compare
@Hugues360 @tigroo @tigroo31 ready for review |
Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
Using [Criterion][1] to add benchmarks in `benches` folder Note that `benches` folder need to be copied in the build Docker image otherwise the build fails [1]: https://github.com/bheisler/criterion.rs Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com> Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
nbuffon
force-pushed
the
rust_mobility_module
branch
from
December 1, 2023 20:49
c1ad495
to
b1c05ae
Compare
Renamed GeoExtension into Quadkey because it is what it is Move the whole thing into mobility mod as quadtree is a positioning solution Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
Using the name Quadtree, despite not being a real implementation of it, to match the mod and because we don't need a specific implementation of it yet or any parsing performance specificaly This could anyway be a good thing to bring a real tree implementation in the future Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
nbuffon
force-pushed
the
rust_mobility_module
branch
from
January 8, 2024 17:09
b1c05ae
to
861d7e4
Compare
tigroo
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bench et test ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
Rust
Rust code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features
Position
struct to manipulate geodesic coordinates using SI units instead of ETSIMobile
trait now uses SI units instead of ETSIGeoExtension
renamed intoQuadkey
as it is now semantically considered a struct on its own and no longer a topic partQuadtree
type to hold a set ofQuadkey
sHow to test
Nothing much to do other than checking that build, tests and benches runs correctly
cargo clean
cargo build
cargo test
cargo bench