Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust mobility module #95

Merged
merged 9 commits into from
Jan 18, 2024
Merged

Conversation

nbuffon
Copy link
Member

@nbuffon nbuffon commented Nov 20, 2023

New features

  • Positionstruct to manipulate geodesic coordinates using SI units instead of ETSI
  • Mobile trait now uses SI units instead of ETSI
  • GeoExtension renamed into Quadkey as it is now semantically considered a struct on its own and no longer a topic part
  • Quadtree type to hold a set of Quadkeys

How to test

Nothing much to do other than checking that build, tests and benches runs correctly

  1. cargo clean
  2. cargo build
  3. cargo test
  4. cargo bench

@nbuffon nbuffon added the enhancement New feature or request label Nov 20, 2023
@nbuffon nbuffon self-assigned this Nov 20, 2023
@nbuffon nbuffon added this to the 2.0.0 milestone Nov 20, 2023
@nbuffon nbuffon changed the title Rust mobility module Draft: Rust mobility module Nov 20, 2023
@nbuffon nbuffon marked this pull request as draft November 20, 2023 20:23
@nbuffon nbuffon added documentation Improvements or additions to documentation Rust Rust code labels Nov 23, 2023
@nbuffon nbuffon requested a review from tigroo November 23, 2023 15:22
Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
@nbuffon nbuffon changed the title Draft: Rust mobility module Rust mobility module Dec 1, 2023
@nbuffon nbuffon marked this pull request as ready for review December 1, 2023 15:32
@nbuffon nbuffon marked this pull request as draft December 1, 2023 15:33
@nbuffon nbuffon changed the base branch from master to 2.0.0 December 1, 2023 15:33
@nbuffon nbuffon marked this pull request as ready for review December 1, 2023 15:33
@nbuffon
Copy link
Member Author

nbuffon commented Dec 1, 2023

@Hugues360 @tigroo @tigroo31 ready for review

Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
Using [Criterion][1] to add benchmarks in `benches` folder

Note that `benches` folder need to be copied in the build Docker image
otherwise the build fails

[1]: https://github.com/bheisler/criterion.rs

Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>

Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
Renamed GeoExtension into Quadkey because it is what it is
Move the whole thing into mobility mod as quadtree is a positioning
solution

Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
Using the name Quadtree, despite not being a real implementation of it, to
match the mod and because we don't need a specific implementation of it
yet or any parsing performance specificaly

This could anyway be a good thing to bring a real tree implementation in
the future

Signed-off-by: Nicolas Buffon <nicolas.buffon@orange.com>
Copy link
Collaborator

@tigroo tigroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bench et test ok

@nbuffon nbuffon merged commit 34bd0df into Orange-OpenSource:2.0.0 Jan 18, 2024
26 checks passed
@nbuffon nbuffon deleted the rust_mobility_module branch February 9, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request Rust Rust code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants