Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

[Fix/ParameterContext] Support optional parametere context and empty slice parameters #157

Merged

Conversation

erdrix
Copy link
Contributor

@erdrix erdrix commented Nov 12, 2021

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets fixes #146
License Apache 2.0

What's in this PR?

It support correctly the optional field ParameterContextRef, so the operator don't crash anymore if you don't set it.
You can define an emply slice for parameters (before the parameter context wasn't created).

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

To Do

  • If the PR is not complete but you want to discuss the approach, list what remains to be done here

@erdrix erdrix self-assigned this Nov 12, 2021
@erdrix erdrix added bug Something isn't working community labels Nov 12, 2021
@erdrix erdrix added this to the 0.7.3 milestone Nov 12, 2021
@erdrix erdrix merged commit de9c802 into Orange-OpenSource:master Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller NifiCluster in endless loop
1 participant