This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
[Feature/Chart] Quick fix for supporting watching multiple namespaces #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 18, 2020 18:21
Signed-off-by: arttii <a.topchyan@reply.de>
Signed-off-by: arttii <a.topchyan@reply.de>
erdrix
suggested changes
Aug 19, 2020
There was a problem hiding this comment.
Thanks for your PR :)
Can you replace this line in the deployment template: https://github.com/Orange-OpenSource/nifikop/blob/master/helm/nifikop/templates/deployment.yaml#L47
By :
- --namespaces={{- join "," .Values.namespaces -}}As in the code we are not managing an array but a string : https://github.com/Orange-OpenSource/nifikop/blob/master/cmd/manager/main.go#L74
|
My mistake, I forgot to commit that line |
Signed-off-by: arttii <a.topchyan@reply.de>
erdrix
changed the title
erdrix
approved these changes
Aug 19, 2020
erdrix
pushed a commit
to erdrix/nifikop
that referenced
this pull request
Sep 16, 2020
…Orange-OpenSource#25) * Update role_binding.yaml * Update role.yaml * Update values.yaml * Add non clustered role as described in Orange-OpenSource#9 Signed-off-by: arttii <a.topchyan@reply.de> * Add changelog Signed-off-by: arttii <a.topchyan@reply.de> * Add missing list to string conversion Signed-off-by: arttii <a.topchyan@reply.de> Signed-off-by: erdrix <alexandre.guitton@orange.com>
erdrix
added a commit
that referenced
this pull request
Sep 16, 2020
* Fix tutorial version (#16) * fix tutorial version * fix blog post Signed-off-by: erdrix <alexandre.guitton@orange.com> * [Fix/Documentation] Chart helm CRDs and some documentations (#18) * fix documentation Signed-off-by: erdrix <alexandre.guitton@orange.com> * clean tool Signed-off-by: erdrix <alexandre.guitton@orange.com> * add v1beta1 version Signed-off-by: erdrix <alexandre.guitton@orange.com> * remove crds from chart and add v1beta1 Signed-off-by: erdrix <alexandre.guitton@orange.com> * update changelog Signed-off-by: erdrix <alexandre.guitton@orange.com> * clean Signed-off-by: erdrix <alexandre.guitton@orange.com> * Bump lodash from 4.17.15 to 4.17.19 in /website Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: erdrix <alexandre.guitton@orange.com> * Bump acorn from 6.4.0 to 6.4.1 in /website Bumps [acorn](https://github.com/acornjs/acorn) from 6.4.0 to 6.4.1. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@6.4.0...6.4.1) Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: erdrix <alexandre.guitton@orange.com> * tmp Signed-off-by: erdrix <alexandre.guitton@orange.com> * [Fix/Documentation] Pattern & versions (#24) * fix documentation Signed-off-by: erdrix <alexandre.guitton@orange.com> * append changelog * append changelog Signed-off-by: erdrix <alexandre.guitton@orange.com> * move v1 into specific folder Signed-off-by: erdrix <alexandre.guitton@orange.com> * add nifi registry client controller Signed-off-by: erdrix <alexandre.guitton@orange.com> * nifi dataflow skeleton Signed-off-by: erdrix <alexandre.guitton@orange.com> * [Feature/Chart] Quick fix for supporting watching multiple namespaces (#25) * Update role_binding.yaml * Update role.yaml * Update values.yaml * Add non clustered role as described in #9 Signed-off-by: arttii <a.topchyan@reply.de> * Add changelog Signed-off-by: arttii <a.topchyan@reply.de> * Add missing list to string conversion Signed-off-by: arttii <a.topchyan@reply.de> Signed-off-by: erdrix <alexandre.guitton@orange.com> * refactor registry client reconcile Signed-off-by: erdrix <alexandre.guitton@orange.com> * clean config Signed-off-by: erdrix <alexandre.guitton@orange.com> * improve dataflow struct and reconcile skeleton Signed-off-by: erdrix <alexandre.guitton@orange.com> * refactor error management Signed-off-by: erdrix <alexandre.guitton@orange.com> * [Fix/Operator] PKI Finalizer namespace (#28) * fix finalizer namespace * append changelog Signed-off-by: erdrix <alexandre.guitton@orange.com> * append changelog Signed-off-by: erdrix <alexandre.guitton@orange.com> * prepare release 0.2.1 (#29) Signed-off-by: erdrix <alexandre.guitton@orange.com> * drop queues Signed-off-by: erdrix <alexandre.guitton@orange.com> * drop & drain, remove Signed-off-by: erdrix <alexandre.guitton@orange.com> * drop & drain, remove Signed-off-by: erdrix <alexandre.guitton@orange.com> * fix dataflow lifecycle Signed-off-by: erdrix <alexandre.guitton@orange.com> * reformat and fix Signed-off-by: erdrix <alexandre.guitton@orange.com> * automate crds generation Signed-off-by: erdrix <alexandre.guitton@orange.com> * fix ordering Signed-off-by: erdrix <alexandre.guitton@orange.com> * conf samples Signed-off-by: erdrix <alexandre.guitton@orange.com> * unit test for clients Signed-off-by: erdrix <alexandre.guitton@orange.com> * add documentation Signed-off-by: erdrix <alexandre.guitton@orange.com> * unit test for clients Signed-off-by: erdrix <alexandre.guitton@orange.com> * add documentation Signed-off-by: erdrix <alexandre.guitton@orange.com> * append changelog Signed-off-by: erdrix <alexandre.guitton@orange.com> * cleaning Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Arttii <artyom.topchyan@live.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Quick fix for supporting watching multiple namespaces
Why?
Needed to support multiple namespaces
Checklist