Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

[Feature/Operator] Manage configmap and secret for override #87

Merged

Conversation

erdrix
Copy link
Contributor

@erdrix erdrix commented Mar 24, 2021

Q A
Bug fix? yes
New feature? yes
API breaks? yes
Deprecations? yes
Related tickets fixes #75
License Apache 2.0

What's in this PR?

It contains an improvement in configuration management :

  • The configuration files are no longer stored in a configmap but in a secret (it allows to secure sensitive information that are stored in the configuration)
  • Added possibility for the .properties files to override the generated configurations providing a configmap or a secret in addition to the OverrideConfigs field into the NifiCluster resource.
  • Added possibility to replace default logback.xml and bootstrap-notification-servces.xml files with a secret or configmap content (secret is prior to the configmap if both are specified)

It also contains a fix that correctly catch configuration changes to trigger the rolling update configuration.

Why?

These new features allow to deal with sensitive information available in configuration, and give more flexibility in configuration management (as proposed in #75)

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@erdrix erdrix self-assigned this Mar 24, 2021
@erdrix erdrix added bug Something isn't working enhancement New feature or request MVP Targeted for the v1 release priority:1 labels Mar 24, 2021
@erdrix erdrix marked this pull request as ready for review March 24, 2021 16:25
@erdrix erdrix merged commit e739910 into Orange-OpenSource:master Mar 24, 2021
@teplydat
Copy link

teplydat commented Apr 1, 2021

@erdrix thank you very much. Looks very well, I already tested it and basically it works.

Two things that I faced with it:

  • I got something like "logbackConfig does not exists in readOnlyConfig" when I tried to apply it via kubectl. I used:
spec:
  readOnlyConfig:
    logbackConfig:
...

It seems the crd is old in the helmchart of 0.6.0.
After recompiling + applying the crd, it just worked like a charm.

  • I just wanted to point the nifikop to namespace "default". But nifikop wants to list namespaces clusterwide (not covered by the helm chart - but I am also not sure why nifikop needs cluster permissions to list namespaces)...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request MVP Targeted for the v1 release priority:1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants