This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
[Feature/Operator] Manage configmap and secret for override #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
It contains an improvement in configuration management :
.properties
files to override the generated configurations providing a configmap or a secret in addition to theOverrideConfigs
field into theNifiCluster
resource.logback.xml
andbootstrap-notification-servces.xml
files with a secret or configmap content (secret is prior to the configmap if both are specified)It also contains a fix that correctly catch configuration changes to trigger the rolling update configuration.
Why?
These new features allow to deal with sensitive information available in configuration, and give more flexibility in configuration management (as proposed in #75)
Checklist