Tooltip: First attempt to get tooltip in bounds anyway #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ods-charts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…can be partially hidden.
julien-deramond
force-pushed
the
main-lmp-popover-fix
branch
from
f3a44d1 to
5e35081
Compare
| if (this.popoverConfig.tooltipConfine) { | ||
| const x = pos[0]; | ||
| const arrowSize = 10; | ||
| const bottom = pos[1] > size.contentSize[1]; // pos[1] > size.viewSize[1] / 2 or pos[1] > size.contentSize[1] or pos[1] > size.viewSize[1] - size.contentSize[1] |
There was a problem hiding this comment.
Future reader, please note that there's a possibility to change the rendering by doing:
// pos[1] > size.viewSize[1] / 2 or pos[1] > size.contentSize[1] or pos[1] > size.viewSize[1] - size.contentSize[1]
julien-deramond
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #99
Description
This PR introduces a new experimental
ODSChartsPopoverConfigproperty namedtooltipConfine. This property is to be used instead of thetooltip.confineproperty in theechartsoptions to have a better control over the tooltip position, and make it stay within the chart area.It also changes the arrow position of the tooltip to follow the mouse position.
Types of change