-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add analytics #136
Docs: Add analytics #136
Conversation
✅ Deploy Preview for ods-charts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as resolved.
This comment was marked as resolved.
We should, but for that we'd probably need to integrate a footer. I let you create another issue to tackle it later on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
Closes #130.
Closes #15.
Description
Should we add a page to manage cookies ? If yes where is the link to it ?
It's quite dirty rn, since it's pure html. The example part is hardcoded but the api part is implemented via
build/tarteaucitron.html
which is minified. Should it be unminifed ?Motivation & Context
Make sure the analytics are made somewhere.
Types of change
Test checklist
Please check that the following tests projects are still working:
docs/examples
test/angular-ngx-echarts
test/angular-echarts
test/html
test/react
test/vue
test/examples/bar-line-chart
test/examples/single-line-chart
test/examples/timeseries-chart