-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A solution for displaying a series with two colours #92 #161
Merged
julien-deramond
merged 6 commits into
main
from
92-a-solution-for-displaying-a-series-with-two-colours
Mar 21, 2024
Merged
A solution for displaying a series with two colours #92 #161
julien-deramond
merged 6 commits into
main
from
92-a-solution-for-displaying-a-series-with-two-colours
Mar 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
✅ Deploy Preview for ods-charts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
louismaximepiton
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this use case
This comment was marked as resolved.
This comment was marked as resolved.
A complement : we probably should use colors from libs and not custom colors in this example |
This comment was marked as resolved.
This comment was marked as resolved.
julien-deramond
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Mar 21, 2024
julien-deramond
approved these changes
Mar 21, 2024
julien-deramond
deleted the
92-a-solution-for-displaying-a-series-with-two-colours
branch
March 21, 2024 11:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
examples
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a solution that doesn't change the library but requires two series to be produced depending on whether or not the objective is achieved