Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the formatter function of the Apache ECharts tooltp in the ods-ch… #197

Conversation

jacques-lebourgeois
Copy link
Member

…arts tooltipSuggest a new feature #194

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Test checklist

Please check that the following tests projects are still working:

  • docs/examples
  • test/angular-ngx-echarts
  • test/angular-echarts
  • test/html
  • test/react
  • test/vue
  • test/examples/bar-line-chart
  • test/examples/single-line-chart
  • test/examples/timeseries-chart

Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for ods-charts ready!

Name Link
🔨 Latest commit 15a6531
🔍 Latest deploy log https://app.netlify.com/sites/ods-charts/deploys/661e472380414500086f8b74
😎 Deploy Preview https://deploy-preview-197--ods-charts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jacques-lebourgeois jacques-lebourgeois marked this pull request as draft April 15, 2024 07:47
@jacques-lebourgeois jacques-lebourgeois force-pushed the 194-use-the-formatter-function-of-the-apache-echarts-tooltp-in-the-ods-charts-tooltipsuggest-a-new-feature branch from 2b6b650 to ce94440 Compare April 15, 2024 07:59
@jacques-lebourgeois jacques-lebourgeois self-assigned this Apr 15, 2024
@jacques-lebourgeois jacques-lebourgeois marked this pull request as ready for review April 15, 2024 08:04
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small questions

docs/use_cases/add-unit.html Outdated Show resolved Hide resolved
docs/use_cases/add-unit.html Outdated Show resolved Hide resolved
docs/use_cases/two-colors-serie.html Show resolved Hide resolved
docs/use_cases/two-colors-serie.html Outdated Show resolved Hide resolved
src/theme/ods-chart-theme.ts Show resolved Hide resolved
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done 🚀

@jacques-lebourgeois jacques-lebourgeois merged commit 73b12a2 into main Apr 18, 2024
4 checks passed
@jacques-lebourgeois jacques-lebourgeois deleted the 194-use-the-formatter-function-of-the-apache-echarts-tooltp-in-the-ods-charts-tooltipsuggest-a-new-feature branch April 18, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the formatter function of the Apache ECharts tooltp in the ods-charts tooltipSuggest a new feature
2 participants