Lib: Use prettier to format our files #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ods-charts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
force-pushed
the
main-lmp-use-prettier
branch
from
07ccfca to
238376b
Compare
Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com>
Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com>
julien-deramond
force-pushed
the
main-lmp-use-prettier
branch
from
238376b to
f070af3
Compare
julien-deramond
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]into- (NA)in the description when things are not applicableRelated issues
NA
Description
Install prettier package
Install prettier extension
Make sure IDE settings.json doesn't conflict with these on save for example (search for settings inside parameters) (at least on workspace)
3 files to review mainly:
.prettierrc,.prettierignoreandpackage.jsonRan
npx prettier . --writeShould we add other formatter/linter ? Mainly thinking about ESLint here but also stylelint could be added. If yes, we might consider adding package that handle the interface between the two (eslint-plugin-prettier).
Motivation & Context
Avoid having several file format depending on the one writing.
Types of change