Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): Availability to specify the colour at the serie level #204

Merged

Conversation

jacques-lebourgeois
Copy link
Member

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Test checklist

Please check that the following tests projects are still working:

  • docs/examples
  • test/angular-ngx-echarts
  • test/angular-echarts
  • test/html
  • test/react
  • test/vue
  • test/examples/bar-line-chart
  • test/examples/single-line-chart
  • test/examples/timeseries-chart

@jacques-lebourgeois jacques-lebourgeois self-assigned this Apr 18, 2024
@jacques-lebourgeois jacques-lebourgeois linked an issue Apr 18, 2024 that may be closed by this pull request
2 tasks
Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for ods-charts ready!

Name Link
🔨 Latest commit c6cee9b
🔍 Latest deploy log https://app.netlify.com/sites/ods-charts/deploys/6627b5e9add0fc0008d7beb0
😎 Deploy Preview https://deploy-preview-204--ods-charts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice addition @jacques-lebourgeois 🚀

It introduces a warning when running: npm run typedoc: [warning] EChartsProject, defined in ./src/theme/ODS.project.ts, is referenced by ODSChartsTheme.theme but not included in the documentation.. This warning can be tackled in a separate PR.

@julien-deramond julien-deramond merged commit 79b042b into main Apr 23, 2024
4 checks passed
@julien-deramond julien-deramond deleted the 196-availability-to-specify-the-colour-at-the-serie-level branch April 23, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Availability to specify the colour at the serie level
2 participants