Add Orange Design System look&feel to default Apache ECharts legends #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
✅ Deploy Preview for ods-charts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9 tasks
9 tasks
2 tasks
louismaximepiton
added a commit
to louismaximepiton/ods-charts
that referenced
this pull request
Jun 5, 2024
louismaximepiton
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
The Apache Echarts looks good right now.
Small remark that could be handled later on:
The legend for ODS Charts should be 8x8px + a border of 1px around that, that does 10px in total. If we agree that, we might want to change values on css-themes.ts, ods-charts-legends.ts and ods-charts-popover.ts.
jacques-lebourgeois
force-pushed
the
241-add-orange-design-system-lookfeel-to-default-apache-echarts-legends
branch
from
4c8e013 to
06953a1
Compare
louismaximepiton
approved these changes
Jun 14, 2024
jacques-lebourgeois
force-pushed
the
241-add-orange-design-system-lookfeel-to-default-apache-echarts-legends
branch
from
06953a1 to
e394a05
Compare
jacques-lebourgeois
deleted the
241-add-orange-design-system-lookfeel-to-default-apache-echarts-legends
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]into- (NA)in the description when things are not applicableRelated issues
Description
Motivation & Context
Types of change
Test checklist
Please check that the following tests projects are still working:
docs/examplestest/angular-ngx-echartstest/angular-echartstest/htmltest/reacttest/vuetest/examples/bar-line-charttest/examples/single-line-charttest/examples/timeseries-chart