Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix three warnings when the documentation is generated (issue #211) #260

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Fix three warnings when the documentation is generated (issue #211) #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5572397
Fix three warnings when the documentation is generated (issue #211)
sebnic Jun 9, 2024
d779725
Merge branch 'main' into issue-211/fix-typedoc-warnings
julien-deramond Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ods-charts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import { ODSChartsTheme } from './theme/ods-chart-theme';

export * from './theme/ods-chart-theme';
export * from './theme/ODS.project';
export * from './theme/css-themes/css-themes';
export * from './theme/popover/ods-chart-popover-definitions';

Expand Down
3 changes: 3 additions & 0 deletions src/theme/ODS.project.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
// This software is distributed under the MIT license.
//

/**
* Echarts theme options
*/
export interface EChartsProject {
color: string[];
backgroundColor: string;
Expand Down
2 changes: 1 addition & 1 deletion src/theme/ods-chart-theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ export class ODSChartsTheme {
* This manager is used to retrieve the Apache ECharts theme and manage the chart options in accordance with the Orange Design System.
*
* The method takes the theme configuration as a parameter {@link ODSChartsThemeOptions}.
* @param options: default option used to generate the theme
* @param options default option used to generate the theme
* @returns the theme manager
*/
public static getThemeManager(options?: ODSChartsThemeOptions): ODSChartsTheme {
Expand Down