Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Apache ECharts from 5.5.0 to 5.5.1 #299

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

julien-deramond
Copy link
Contributor

@julien-deramond julien-deramond commented Jul 2, 2024

Closes #289

Description

Go through the entire list of the release note to evaluate the impacts, enhancements, etc. we can/must do in ODS Charts. Source: https://github.com/apache/echarts/releases/tag/5.5.1:

  • Feature axis: support custom axis tick/label positions:
    • this new customValues for axisTick and axisLabel doesn't have any impact on the library, since it's a new option.
    • there's no issue to create in our repository, as it's not something we could introduce by default for our rendering.
  • Feature bar: add startValue option:
    • this new startValue option doesn't have any impact on the library, since it's a new option.
    • there's no issue to create in our repository, as it's not something we could introduce by default for our rendering.
  • Feature sankey: add itemStyle.borderRadius option
    • this new option doesn't have any impact on the library, it's a new option that won't be used for our rendering as there's generally no border radius in Orange interfaces
    • there's no issue to create in our repository, as it's not something we could introduce by default for our rendering.
  • Feature time: add meridian template {a}/{A}: nothing to do in our library as this is just a new time formatting
  • Feature geo: add totalZoom parameter for the georoam event: nothing to do as we don't use the georoam event
  • Feature treemap: add scaleLimit option to limit the zooming: nothing to do as we don't use the Treemap.
  • Fix series: avoid error caused by seriesData.getLinkedData: no impact as we don't use seriesData.getLinkedData
  • Fix marker: fix marker label formatter can't get series information: nothing to do as we never experienced this issue in our tests
  • Fix aria: avoid error in SSR mode: nothing to do as we don't use SSR mode
  • Fix data: avoid error when using BigInt values: nothing to do as we don't have any examples with BigInt values
  • Fix pie: fix endAngle is not applied on the empty circle: nothing to do as we don't have yet pie charts. Moreover, WIP PR Examples: Add pie and donut charts #88 doesn't use endAngle
  • Fix toolbox: fix uncaught reference error in the environment that MouseEvent doesn't exist: nothing to do as we didn't experience this issue
  • Fix tooltip: fix tooltip XSS issue when legend name is HTML string: nothing to do, the encodeHTMLContent when the HTML render mode is used doesn't cause any issues in our current examples using popovers (with ODSChartsPopover).
  • Fix type: fix that in users' .d.ts import('echarts/types/dist/shared') can not visit 'echarts/types/dist/shared.d.ts' since v5.5.0: nothing to do, no direct impact on our library

I've also checked the compatibility with angular-ngx-echarts and didn't observe any regressions. No issues related to this new 5.5.1 is created in their repository, so it's probably already compatible.

Test checklist

Please check that the following tests projects are still working:

  • docs/examples
  • test/angular-ngx-echarts
  • test/angular-echarts
  • test/html
  • test/react
  • test/vue
  • test/examples/bar-line-chart
  • test/examples/single-line-chart
  • test/examples/timeseries-chart

@julien-deramond julien-deramond added chore dependencies Pull requests that update a dependency file labels Jul 2, 2024
Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for ods-charts ready!

Name Link
🔨 Latest commit 973dcc1
🔍 Latest deploy log https://app.netlify.com/sites/ods-charts/deploys/668b83bcc9d7950008e4dc7a
😎 Deploy Preview https://deploy-preview-299--ods-charts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond changed the title chore(deps-dev): bump echarts from 5.5.0 to 5.5.1 Bump Apache ECharts from 5.5.0 to 5.5.1 Jul 2, 2024
@julien-deramond julien-deramond marked this pull request as ready for review July 8, 2024 06:08
@julien-deramond julien-deramond marked this pull request as draft July 8, 2024 06:08
@julien-deramond julien-deramond marked this pull request as ready for review July 8, 2024 06:14
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [Feature] [axis] Support custom axis tick/label positions. Shouldn't impact us
  • [Feature] [bar] Add startValue option. Shouldn't impact us
  • [Feature] [sankey] Add itemStyle.borderRadius option. Shouldn't impact us
  • [Feature] [time] Add meridian template {a}/{A}. No impact for us
  • [Feature] [geo] Add totalZoom parameter for the georoam event. No impact for us
  • [Feature] [treemap] Add scaleLimit option to limit the zooming. No impact for us
  • [Fix] [series] Avoid error caused by seriesData.getLinkedData. No impact
  • [Fix] [marker] Fix marker label formatter can't get series information. Could be great, but no direct impact
  • [Fix] [aria] Avoid error in SSR mode. No impact
  • [Fix] [data] Avoid error when using BigInt values.
  • [Fix] [pie] Fix endAngle is not applied on the empty circle.
  • [Fix] [toolbox] Fix uncaught reference error in the environment that MouseEvent doesn't exist.
  • [Fix] [tooltip] Fix tooltip XSS issue when legend name is HTML string.
  • [Fix] [type] Fix that in users' .d.ts import('echarts/types/dist/shared') can not visit 'echarts/types/dist/shared.d.ts' since v5.5.0.

@julien-deramond julien-deramond merged commit 7ef3fcd into main Jul 8, 2024
5 checks passed
@julien-deramond julien-deramond deleted the main-jd-bump-echarts-to-5.5.1 branch July 8, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Study: Apache ECharts 5.5.1
2 participants