Skip to content

Commit

Permalink
feat: add custom app icon for debug / debug builds
Browse files Browse the repository at this point in the history
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
  • Loading branch information
pylapp committed Oct 29, 2024
1 parent 2437b93 commit 541f612
Show file tree
Hide file tree
Showing 8 changed files with 24 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

- [DemoApp] App icons for alpha, beta and production releases ([#140](https://github.com/Orange-OpenSource/ouds-ios/issues/140))
- [DemoApp] App icons for debug, alpha, beta and production releases ([#140](https://github.com/Orange-OpenSource/ouds-ios/issues/140))
- [Tool] GitHub Actions workflow for CI/CD ([#256](https://github.com/Orange-OpenSource/ouds-ios/issues/256))
- [DemoApp] Add new tokens in size tokens page ([#245](https://github.com/Orange-OpenSource/ouds-ios/issues/245))
- [Library] Semantic token `borderWidthFocusInset` (value of `borderWidth100`) ([#207](https://github.com/Orange-OpenSource/ouds-ios/issues/207), [#241](https://github.com/Orange-OpenSource/ouds-ios/issues/241))
Expand Down
2 changes: 1 addition & 1 deletion Showcase/Showcase.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -1052,7 +1052,7 @@
isa = XCBuildConfiguration;
baseConfigurationReference = F98488CF05532E8CD405A8F8 /* Pods-Showcase.debug.xcconfig */;
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIconDev;
ASSETCATALOG_COMPILER_APPICON_NAME = AppIconDebug;
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
ASSETCATALOG_COMPILER_INCLUDE_ALL_APPICON_ASSETS = YES;
CODE_SIGN_STYLE = Automatic;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"images" : [
{
"filename" : "UDSDemo-A_CROP.png",
"filename" : "UDSDemo-A_SQR.png",
"idiom" : "universal",
"platform" : "ios",
"size" : "1024x1024"
Expand Down
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"images" : [
{
"filename" : "UDSDemo-DEBUG_SQR.png",
"idiom" : "universal",
"platform" : "ios",
"size" : "1024x1024"
}
],
"info" : {
"author" : "xcode",
"version" : 1
}
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 7 additions & 2 deletions Showcase/fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,11 @@ platform :ios do
clean_install: true
)

Dir.chdir "../Showcase/Resources/Assets.xcassets" do
sh "rm -Rf AppIconRelease.appiconset"
sh "cp -R AppIconDebug.appiconset AppIconRelease.appiconset"
end

gym(
scheme: OUDS_SCHEME,
output_directory: 'build/',
Expand Down Expand Up @@ -205,7 +210,7 @@ platform :ios do

Dir.chdir "../Showcase/Resources/Assets.xcassets" do
sh "rm -Rf AppIconRelease.appiconset"
sh "cp -R AppIconDev.appiconset AppIconRelease.appiconset"
sh "cp -R AppIconAlpha.appiconset AppIconRelease.appiconset"
end

# CFBundleVersion and CFBundleShortVersionString must follow rules with integers and periods, should not change them
Expand All @@ -230,7 +235,7 @@ platform :ios do
puts "👉 Beta (commit hash = '#{params[:commitHash]}')"
Dir.chdir "../Showcase/Resources/Assets.xcassets" do
sh "rm -Rf AppIconRelease.appiconset"
sh "cp -R AppIconQualif.appiconset AppIconRelease.appiconset"
sh "cp -R AppIconBeta.appiconset AppIconRelease.appiconset"
end

new_display_name = "OUDS Showcase (BETA)"
Expand Down

0 comments on commit 541f612

Please sign in to comment.