Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dimension token] Rename Size and Space tokens #237

Closed
1 task done
ludovic35 opened this issue Oct 23, 2024 · 0 comments · Fixed by #246
Closed
1 task done

[Dimension token] Rename Size and Space tokens #237

ludovic35 opened this issue Oct 23, 2024 · 0 comments · Fixed by #246
Assignees
@pylapp
Labels
📀 token Related to tokens (raws, semantics or components)

Comments

@ludovic35
Copy link
Member

Prerequisites

As a

developper

... I want to

rename token

... so that I can

have the right name of token according to figma

Motivation and context

No response

Proposed Solution

No response

Other

No response

Contact Details

No response
@ludovic35 ludovic35 added the 🔍 triage A new issue that needs to be treated label Oct 23, 2024
@pylapp pylapp added 📀 token Related to tokens (raws, semantics or components) and removed 🔍 triage A new issue that needs to be treated labels Oct 23, 2024
@pylapp pylapp moved this to Todo in [OUDS] Project Oct 23, 2024
@pylapp pylapp moved this from Todo to In Progress in [OUDS] Project Oct 24, 2024
pylapp added a commit that referenced this issue Oct 24, 2024
@pylapp
refactor: rename *Spacing*Tokens and *Sizing*Tokens to `*Space*To…
dc42745 
…kens` and `*Size*Tokens` (#237)

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
@pylapp pylapp linked a pull request Oct 24, 2024 that will close this issue
[#237] Rename size and space tokens #246
Merged
pylapp added a commit that referenced this issue Oct 24, 2024
@pylapp
refactor: rename *Spacing*Tokens and *Sizing*Tokens to `*Space*To…
d563769 
…kens` and `*Size*Tokens`, various cleanings (#237) (#246

- Rename tokens types
- Clean some files and warnings

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in [OUDS] Project Oct 24, 2024
pylapp added a commit that referenced this issue Oct 31, 2024
@pylapp @ludovic35 @boosted-bot
Release 0.5.0 (#269)
5ce9b68 
Release of version 0.5.0
See below the full CHANGELOG details.

Added:
- [DemoApp] App icons for debug, alpha, beta and production releases ([#140](#140))
- [Tool] GitHub Actions workflow for CI/CD ([#256](#256))
- [DemoApp] Add new tokens in size tokens page ([#245](#245))
- [Library] Semantic token `borderWidthFocusInset` (value of `borderWidth100`) ([#207](#207), [#241](#241))
- [Library] Semantic token `fontWeightCode` ([#242](#242))
- [DemoApp] Update space tokens screen with all categories ([#178](#178))

Changed:
- [Library] Update `ElevationSemanticTokens` (tokenator *20241031125053*)
- [Library] Update `OrangeBrandColorRawTokens` (tokenator *20241030132734*)
- [Library] Update `BorderSemanticTokens` (tokenator *20241025110844*)
- [Library] Rename color semantic tokens `colorBackground*` to `colorBg*`
- [Library] Rename `MultipleSpacingTokens` to `MultipleSpaceTokens` and `MultipleSizingTokens` to `MultipleSizeTokens`
- [Library] Extract composite semantic tokens from semantic tokens (`ElevationSemanticTokens`, `TypographySemanticTokens`)
- [Library] Improve documentation about the use of semantic tokens
- [Library] Update `OpacitySemanticTokens` (tokenator *20241025101305*)
- [Library] Rename `*Spacing*Tokens` and `*Sizing*Tokens` to `*Space*Tokens` and `*Size*Tokens` ([#237](#237))
- [Library] Update `ElevationRawTokens` (tokenator *20241022174330*)
- [Library] Update `DimensionRawTokens` (tokenator *20241022132646*)
- [Tool] Improve configuration of SwiftLint, update to v0.57.0 ([#77](#77))
- [Library] Rename all color semantic tokens `*OnBackground*` to `*OnBg*` ([#208](#208))
- [Library] Rename `colorDecorativeBrandTertiary` to `colorDecorativeTertiary`
- [Library] Rename `colorDecorativeBrandPrimary` to `colorDecorativePrimary` ([#208](#208))
- [Library] Rename `colorDecorativeSkinTint*` to `colorDecorativeSkinTint*`
- [Library] Rename `colorActionVisitedOnBackgroundEmphasized` to `colorActionVisitedOnBgEmphasized` ([#208](#208))
- [Library] Update color semantic tokens ([#208](#208))
- [Library] Update `BorderRawTokens` (tokenator *20241022102003*)
- [Library] Update `ColorRawTokens` (tokenator *20241021180411*)
- [Tool] Migration to Swift 6
- [Tool] Migration from *Xcode 15.3* to to *Xcode 16* ([#201](#201))
- [Library] Rename `borderWidthOutsideFocus` to `borderWidthFocus` ([#207](#207))
- [Library] Update `OpacityRawTokens` (tokenator *20241021134644*)

Removed:
- [Library] Semantic tokens `colorDecorativeBrandTertiaryMuted`, `colorDecorativeBrandTertiaryEmphasized` ([#208](#208))
- [Library] Semantic tokens `colorDecorativeBrandSecondaryMuted`, `colorDecorativeBrandSecondaryEmphasized` ([#208](#208))
- [Library] Semantic tokens `colorDecorativeBrandPrimaryMuted`, `colorDecorativeBrandPrimaryEmphasized` ([#208](#208))
- [Library] Semantic tokens `elevationBlurFocus`, `elevationXFocus`, `elevationYFocus`, `elevationColorFocus` ([#209](#209))

Fixed:
- [DemoApp] Update typography screen to use right color on token name ([#213](#213))
- [DemoApp] Remove duplicated section in color page for content on background values ([#236](#236))
- [DemoApp] Hide from Voice Over decorative image in theme selector (a11y)

Security:
- [Tool] Move to Ruby 3.3.5 to fix Dependabot alert about *REXML ReDoS vulnerability* (CVE-2024-49761) ([#5](https://github.com/Orange-OpenSource/ouds-ios/security/dependabot/5))

Co-authored-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Co-authored-by: Ludovic Pinel <ludovic.pinel@orange.com>
Co-authored-by: boosted-bot <boosted-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pylapp pylapp

Labels
📀 token Related to tokens (raws, semantics or components)
Projects
[OUDS] Project
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#237] Rename size and space tokens Orange-OpenSource/ouds-ios
3 participants
@pylapp @ludovic35 @Tayebsed93