Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Token Update] Remove useless semantic tokens for dimension #308

Closed
3 of 13 tasks
pylapp opened this issue Nov 26, 2024 · 0 comments
Closed
3 of 13 tasks

[Token Update] Remove useless semantic tokens for dimension #308

pylapp opened this issue Nov 26, 2024 · 0 comments
Assignees
@pylapp
Labels
📀 token Related to tokens (raws, semantics or components)

Comments

@pylapp
Copy link
Member

pylapp commented Nov 26, 2024 •
edited
Loading

Type of tokens

  • Raw token (i.e. associated to SwiftUI or Swift value)
  • Semantic token (i.e. pointing to a raw token)
  • Component token (i.e. pointing to a semantic token, used for a component)

Description

Context

Some semantic tokens are defined in the current iOS codebase but are not supposed to be.
In fact, suched closed tokens are indeed defined in Figjam but only for the design team and not the development team
These tokens must be removed.

Definition of Done

  • Remove dimension semantic tokens (e.g. dimensionNone, dimension10XS, etc)
  • Remove any sysColorBrand* tokens
  • Update documentations use such sysColorBrand* tokens

Motivation & Context

  • Provide less otkens
  • Get rid of unmanaged tokens

Types of change

  • Add new tokens
  • Update existing tokens (i.e. change name or value)
  • Remove existing token

Checklist for Core Team

  • Tokens have been updated
  • Documentations have been updated
  • Unit tests have been updated
  • Retrocompatibility has been checked, or broken API have been flagged as deprecated with a workaround
@pylapp pylapp added 📀 token Related to tokens (raws, semantics or components) 🔍 triage A new issue that needs to be treated labels Nov 26, 2024
@pylapp pylapp self-assigned this Nov 26, 2024
@pylapp pylapp moved this from Triage to In Progress in [OUDS] Project Nov 26, 2024
@pylapp pylapp changed the title [Token Update] [Token Update] Remove useless semantic tokens for dimension Nov 26, 2024
@pylapp pylapp closed this as completed in b9220c1 Nov 26, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in [OUDS] Project Nov 26, 2024
@pylapp pylapp removed the 🔍 triage A new issue that needs to be treated label Nov 26, 2024
@pylapp pylapp mentioned this issue Nov 29, 2024
Merged
pylapp added a commit that referenced this issue Nov 29, 2024
@pylapp @ludovic35
@Tayebsed93 @boosted-bot
Version 0.7.0 (#324)
7463f43 
Release of version 0.7.0
See below the full CHANGELOG details.

Added:
- [DemoApp] Add code sample for tokens usages in token pages ([#283](#283))
- [Library] Color some new semantic tokens `colorContentStatus*`,  `colorContentOnBrand*`, `colorContentOnStatus*`, `colorGradient*`, `colorBorder*`, `colorContentOnAction*`
- [Tool] Add UI tests in CI/CD pipelines ([#298](#298))
- [DemoApp] Add more UI tests on demo app ([#154](#154))

Changed:
- [Library] Update `GridSemanticTokens` tokens (tokenator *20241129080807*)
- [Library] Types `GridExtraCompactSemanticToken`, `GridCompactSemanticToken` and `GridRegularSemanticToken` replaced by `GridSemanticToken` to make tokenator updates integration easier 
- [DemoApp] Update space tokens screen ([#275](#275))
- [Library] Update `GridRawTokens` tokens (tokenator *20241128161629*)
- [DemoApp] Update color tokens screen 
- [Library] Update `ColorSemanticTokens` tokens (tokenator *20241127112301*)
- [Library] Update `SpaceSemanticTokens` tokens (tokenator *20241127074206*)
- [Library] Update `SizeSemanticTokens` with rename of tokens (tokenator *20241126134156*)
- [Library] Update `ElevationSemanticTokens` (tokenator *20241126120657*)
- [Library] Improve Multiple-based objects for tokenator values integration ([#279](#279))
- [Tool] Use `macos-15` runner for GitHub Actions builds ([#296](#296))

Removed:
- [Library] Grid semantic tokens `gridExtraCompactColumnCount`, `gridCompactColumnCount` and `gridRegularColumnCount`
- [Library] Grid raw tokens `gridMargin900`
- [Library] Color semantic tokens `colorContentOnBg*`, `colorBorderOnBg*`, `colorBorderStatus*`, some `colorAction*OnBg*`, `colorDecorative{Primary,Secondary,Tertiary}`, `colorAlwaysOnBg*`, `colorBgBrand{Secondary,Tertiary}`, `colorContentBrand{Secondary,Tertiary}`, `colorBorderBrand{Secondary,Tertiary}`, `colorContentStatusAccent`, ...
- [Library] Some space semantic tokens type aliases to help tokenator job (`SpacePaddingInlineSemanticToken`, `SpacePaddingBlockSemanticToken`, `SpaceGapInlineSemanticToken`, `SpaceGapStackSemanticToken`)
- [Library] All dimension semantic tokens ([#308](#308))

Fixed:
- [DemoApp] Fix VoiceOver issue with element grouping in presentation tokens and update accessibility statement ([#212](#285))
- [Library] Warning issues for DocC catalogs ([#293](#293))

Co-authored-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Co-authored-by: Ludovic Pinel <ludovic.pinel@orange.com>
Co-authored-by: Tayeb Sedraia <tayeb.sedraia@orange.com>
Co-authored-by: boosted-bot <boosted-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pylapp pylapp

Labels
📀 token Related to tokens (raws, semantics or components)
Projects
[OUDS] Project
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pylapp