Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming Typography* to Font* #322

Closed
julien-deramond opened this issue Nov 29, 2024 · 0 comments · Fixed by #342
Closed

Renaming Typography* to Font* #322

julien-deramond opened this issue Nov 29, 2024 · 0 comments · Fixed by #342
Assignees
@pylapp
Labels
📀 token Related to tokens (raws, semantics or components)

Comments

@julien-deramond
Copy link
Contributor

julien-deramond commented Nov 29, 2024 •
edited
Loading

Fonts tokens are the latest raw + semantic tokens to sync with Figma.

There's a little preparation work to do before on your side to receive files generated from OUDS Tokenator.

  • TypographyRawTokens+Values.swift must be renamed to FontRawTokens+Values.swift (and so the extension name as well)
  • OUDSTheme+TypographySemanticTokens.swift must be renamed to OUDSTheme+FontSemanticTokens.swift (and so the extension name as well)
    • The types in this file must be renamed too: Typography* → Font (e.g. TypographyFontFamilySemanticToken → FontFamilySemanticToken)
  • Basically, most of the things that are named Typography* should be Font*; "typography" doesn't exist on the tokens side.
@julien-deramond julien-deramond added the 📀 token Related to tokens (raws, semantics or components) label Nov 29, 2024
@pylapp pylapp moved this from Triage to In Progress in [OUDS] Project Dec 10, 2024
@pylapp pylapp mentioned this issue Dec 10, 2024
Merged
19 tasks
@pylapp pylapp linked a pull request Dec 10, 2024 that will close this issue
[#322] Renaming of typography tokens to font tokens #342
Merged
19 tasks
pylapp added a commit that referenced this issue Dec 10, 2024
@pylapp
refactor: renaming of "typography" tokens to "font" tokens (#322) (#342)
7c5f492 
- Rename semantic and raw tokens
- Update unit tests
- Update UI tests
- Update documentation
- Update demo app

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in [OUDS] Project Dec 10, 2024
This was referenced Dec 18, 2024
Merged
Merged
pylapp added a commit that referenced this issue Dec 18, 2024
@pylapp @ludovic35 @boosted-bot
Version 0.8.0 (#357)
921db77 
Release of version 0.8.0
See bellow the full CHANGELOG details.

Added:
- [Library] New architecture with tokens provider ([#79](#79))
- [DemoApp] Prepare new architecture to add components illustration ([#328](#328))

Changed:
- [Tool] Update `net-http` gem from 0.5.0 to 0.6.0
- [Tool] Update `SwiftLint` pod from v0.57.0 to v0.57.1
- [Tool] Update `SwiftFormat/CLI` pod from v0.54.6 to v0.55.3
- [Tool] Update `fastlane` gem from v2.225.0 to v2.226.0
- [Library] Update `FontSemanticTokens` (tokenator *20241213075501*)
- [Library] Update `FontSemanticTokens` (tokenator *20241211115813*)
- [Library] Update `FontRawTokens` (tokenator *20241211101443*)
- [Tool] Migrate from `xcode_install` to `xcodes` in Fastfile, freeze Xcode version (16.0)
- [Library] Rename `Typography*` tokens and elements to `Font*` ([#322](#322))
- [Library] Update `ColorSemanticTokens` (tokenator *20241204111709*)
- [Library] Update `SpaceSemanticTokens` (tokenator *20241204110127*)
- [Library] Rename `opacityTransparent` opacity semantic token to `opacityInvisible`
- [Library] Update `OpacitySemanticTokens` and `OpacityRawTokens` tokens (tokenator *20241204110957*)
- [Library] Update `OrangeBrandColorRawTokens` tokens (tokenator *20241204111119*)
- [Library] Update `SizeSemanticTokens` tokens (tokenator *20241204110236*)
- [Library] Rename any `sizeIcon**` size semantic tokens applying "T-shirt sizes" template
- [Library] Update `ElevationSemanticTokens` and `ColorRawTokens` tokens (tokenator *20241204111249*)
- [Library] Rename any `colorTransparent*` color semantic tokens to `colorOpacity*`
- [DemoApp] Reactor UI test to use theme in environment ([#299](#299))

Removed:
- [Library] Font raw tokens `fontFamilyBrandDefault`, `fontFamilyBrandTV`, `fontFamilySystemArial`, `fontFamilySystemHelvetica`, `fontFamilySystemNotoSans`, `fontFamilySystemSFPro`, `fontFamilySystemRoboto`, `fontFamilyMonospaceMonaco`, `fontFamilyMonospaceCourierNew`, `fontFamilySystemArial`
- [Library] Space semantic tokens `*WithIcon*`, `*WithArrow*` 
- [Library] Elevation semantic tokens `elevationBlurOverlayDefault`, `elevationBlurOverlayEmphasized`, `elevationXOverlayDefault`, `elevationXOverlayEmphasized`, `elevationYOverlayDefault`, `elevationYOverlayEmphasized`, `elevationColorOverlayDefaultLight`, `elevationColorOverlayEmphasizedLight`, `elevationColorOverlayDefaultDark`, `elevationColorOverlayEmphasizedDark`

Co-authored-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Co-authored-by: Ludovic Pinel <ludovic.pinel@orange.com>
Co-authored-by: boosted-bot <boosted-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pylapp pylapp

Labels
📀 token Related to tokens (raws, semantics or components)
Projects
[OUDS] Project
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#322] Renaming of typography tokens to font tokens Orange-OpenSource/ouds-ios
2 participants
@pylapp @julien-deramond