Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#119] Remove tokens elevationZIndex and add elevationX200 #121

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

pylapp
Copy link
Member

@pylapp pylapp commented Sep 20, 2024

Closes #119

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#119

Description

  • Add missing raw toekn elevation X 200
  • Remove Z Index raw tokens for elevations

Motivation & Context

Types of change

  • Refactoring (non-breaking change)

Previews

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices

Design

  • (NA) My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibiltiy review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

Closes #119

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
@pylapp pylapp self-assigned this Sep 20, 2024
@pylapp pylapp requested a review from ludovic35 as a code owner September 20, 2024 14:35
@pylapp
Copy link
Member Author

pylapp commented Sep 20, 2024

@ludovic35 Ready for review :)

For the merge commit message, use for example:

refactor: remove tokens `elevationZIndex` and add `elevationX200`(#119) (#121)

@ludovic35 ludovic35 merged commit d6f4268 into develop Sep 23, 2024
3 of 4 checks passed
@ludovic35 ludovic35 deleted the 119-add-elevationX200 branch September 23, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add raw token elevationX200 and remove raw elevationZIndex
2 participants