Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

844 update accessibility statement usage #277

Merged
merged 11 commits into from
Nov 13, 2024

Conversation

Tayebsed93
Copy link
Collaborator

@Tayebsed93 Tayebsed93 commented Nov 12, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • Design review has been done
  • Accessibiltiy review has been done
  • Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

@Tayebsed93 Tayebsed93 marked this pull request as draft November 12, 2024 19:00
@pylapp pylapp force-pushed the develop branch 5 times, most recently from b30d5db to 01278b8 Compare November 13, 2024 09:54
@Tayebsed93 Tayebsed93 force-pushed the 844-update-accessibility-statement-usage branch from 864b30f to c1e9e90 Compare November 13, 2024 10:51
@Tayebsed93 Tayebsed93 marked this pull request as ready for review November 13, 2024 11:08
@pylapp
Copy link
Member

pylapp commented Nov 13, 2024

@Tayebsed93 C'est quoi ce numéro d'issue ? "844" ne correspond à rien du tout ici !

@pylapp pylapp self-assigned this Nov 13, 2024
Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actions à prendre :

  • Synchroniser ta branche
  • Revoir le CHANGELOG
  • Revoir le THIRD-PARTY

CHANGELOG.md Outdated Show resolved Hide resolved
THIRD_PARTY.md Outdated Show resolved Hide resolved
THIRD_PARTY.md Outdated Show resolved Hide resolved
@Tayebsed93 Tayebsed93 force-pushed the 844-update-accessibility-statement-usage branch from 130a585 to 1876ce8 Compare November 13, 2024 12:36
@Tayebsed93 Tayebsed93 force-pushed the 844-update-accessibility-statement-usage branch from db0f18a to ab20cf1 Compare November 13, 2024 12:45
@pylapp pylapp merged commit 566dd06 into develop Nov 13, 2024
4 of 7 checks passed
@pylapp pylapp deleted the 844-update-accessibility-statement-usage branch November 13, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update accessibility statement Usage
2 participants