Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#285] Fix VoiceOver issue with element grouping in presentation tokens for demo app #292

Merged
merged 5 commits into from
Nov 20, 2024
Merged

[#285] Fix VoiceOver issue with element grouping in presentation tokens for demo app #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
80fd316
fix: group elements together for better a11y
Tayebsed93 Nov 15, 2024
b5634ac
fix: update accessibility score
Tayebsed93 Nov 15, 2024
cb34b1a
docs : add issue reference to CHANGELOG.md
Tayebsed93 Nov 15, 2024
72e56d1
review: changelog fix position
Tayebsed93 Nov 19, 2024
2d6c842
review: update CHANGELOG.md
Tayebsed93 Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased](https://github.com/Orange-OpenSource/ouds-ios/compare/0.6.0...develop)

### Fixed

- [Library] Warning issues for DocC catalogs ([#293](https://github.com/Orange-OpenSource/ouds-ios/issues/293))
### Changed

- [Tool] Use `macos-15` runner for GitHub Actions builds ([#296](https://github.com/Orange-OpenSource/ouds-ios/issues/296))

### Fixed

- [DemoApp] Fix VoiceOver issue with element grouping in presentation tokens and update accessibility statement ([#212](https://github.com/Orange-OpenSource/ouds-ios/issues/285))
- [Library] Warning issues for DocC catalogs ([#293](https://github.com/Orange-OpenSource/ouds-ios/issues/293))

## [0.6.0](https://github.com/Orange-OpenSource/ouds-ios/compare/0.5.0...0.6.0) - 2024-11-15

### Added
Expand Down
1 change: 1 addition & 0 deletions Showcase/Showcase/Pages/Tokens/Dimension/Size/SizeTokenPage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ struct SizeTokenPage: View {
.typeBodyDefaultMedium(theme)
.foregroundStyle(theme.colorContentMuted.color(for: colorScheme))
}
.accessibilityElement(children: .combine)
}
}

Expand Down
1 change: 1 addition & 0 deletions Showcase/Showcase/Pages/Tokens/Typography/TypographyTokenPage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,6 @@ struct TypographyTokenPage: View {
}
.frame(maxWidth: .infinity, alignment: .leading)
.padding(.vertical, theme.spaceFixedShorter)
.accessibilityElement(children: .combine)
}
}
1 change: 1 addition & 0 deletions Showcase/Showcase/Pages/Utils/ShowcaseTokenIllustration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ struct ShowcaseTokenIllustration<TokenIllustration>: View where TokenIllustratio
}
}
.frame(maxWidth: .infinity, alignment: .leading)
.accessibilityElement(children: .combine)
}
.padding(.vertical, theme.spaceFixedShorter)
}
Expand Down
66 changes: 31 additions & 35 deletions Showcase/Showcase/Resources/accessibilityStatement/accessibility_detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ <h2 class="h4 mt-4">Context</h2>
<p>This accessibility statement applies to the Orange Unified Design System.</p>



</div>

</div>
Expand All @@ -48,26 +47,26 @@ <h2 class="h4 mt-4">Conformity level:</h2>

<h3>Tests result</h3><div class="row summary">
<div class="col-lg-auto text-center">
<h4 class="pie" data-value="94">
<h4 class="pie" data-value="97">
<span class="visually-hidden">Global compliance </span>
<span class="pie-val">94%</span>
<span class="pie-val">97%</span>
</h4>

<p class="lead">Global compliance
</p>
</div>
<div class="col-lg-auto text-center">
<h4 class="pie" data-value="96">
<h4 class="pie" data-value="98">
<span class="visually-hidden">Average compliance </span>
<span class="pie-val">96%</span>
<span class="pie-val">98%</span>
</h4>

<p class="lead">Average compliance</p>
</div>
</div><p>The compliance audit carried out by Service interne reveals that :</p>
<ul>
<li>94% of WCAG level A and AA criteria are met.</li>
<li>The average compliance rate of the online service is 96%.</li>
<li>97% of WCAG level A and AA criteria are met.</li>
<li>The average compliance rate of the online service is 98%.</li>
</ul>
<div class="table-responsive">
<table class="table table-striped"><caption>Summary by levels</caption>
Expand All @@ -89,16 +88,16 @@ <h4 class="pie" data-value="96">

<tr>
<th scope="row" class="font-weight-bold">Compliant</th>
<td class="text-center">18</td>
<td class="text-center">19</td>
<td class="text-center">14</td>
<td class="text-center">32</td>
<td class="text-center">33</td>
</tr>

<tr>
<th scope="row" class="font-weight-bold">Non-compliant</th>
<td class="text-center">0</td>
<td class="text-center">1</td>
<td class="text-center">1</td>
<td class="text-center">2</td>
</tr>

<tr>
Expand All @@ -111,13 +110,13 @@ <h4 class="pie" data-value="96">
<tr>
<th scope="row" class="font-weight-bold bg-light">Compliance</th>
<td class="text-center bg-light">
95%
100%
</td>
<td class="text-center bg-light">
93%
</td>
<td class="text-center bg-light">
94%
97%
</td>
</tr>

Expand Down Expand Up @@ -151,58 +150,58 @@ <h4 class="pie" data-value="96">
<td style="background-color:#ddd !important;">97 %</td>
</tr><tr>
<th scope="row"><span class="visually-hidden">Page : </span>Border</th>
<td>18</td>
<td>19</td>
<td>14</td>
<td>1</td>
<td>0</td>
<td>1</td>
<td>13</td>
<td>9</td>
<td style="background-color:#ddd !important;">94 %</td>
<td style="background-color:#ddd !important;">97 %</td>
</tr><tr>
<th scope="row"><span class="visually-hidden">Page : </span>Corlor</th>
<td>18</td>
<td>14</td>
<td>1</td>
<td>1</td>
<td>19</td>
<td>15</td>
<td>0</td>
<td>0</td>
<td>13</td>
<td>9</td>
<td style="background-color:#ddd !important;">94 %</td>
<td style="background-color:#ddd !important;">100 %</td>
</tr><tr>
<th scope="row"><span class="visually-hidden">Page : </span>Dimension</th>
<td>18</td>
<td>19</td>
<td>14</td>
<td>1</td>
<td>0</td>
<td>1</td>
<td>13</td>
<td>9</td>
<td style="background-color:#ddd !important;">94 %</td>
<td style="background-color:#ddd !important;">97 %</td>
</tr><tr>
<th scope="row"><span class="visually-hidden">Page : </span>Elevation</th>
<td>18</td>
<td>19</td>
<td>14</td>
<td>1</td>
<td>0</td>
<td>1</td>
<td>13</td>
<td>9</td>
<td style="background-color:#ddd !important;">94 %</td>
<td style="background-color:#ddd !important;">97 %</td>
</tr><tr>
<th scope="row"><span class="visually-hidden">Page : </span>Opacity</th>
<td>18</td>
<td>19</td>
<td>14</td>
<td>1</td>
<td>0</td>
<td>1</td>
<td>13</td>
<td>9</td>
<td style="background-color:#ddd !important;">94 %</td>
<td style="background-color:#ddd !important;">97 %</td>
</tr><tr>
<th scope="row"><span class="visually-hidden">Page : </span>Typography</th>
<td>18</td>
<td>19</td>
<td>14</td>
<td>1</td>
<td>0</td>
<td>1</td>
<td>13</td>
<td>9</td>
<td style="background-color:#ddd !important;">94 %</td>
<td style="background-color:#ddd !important;">97 %</td>
</tr><tr>
<th scope="row"><span class="visually-hidden">Page : </span>Components</th>
<td>19</td>
Expand Down Expand Up @@ -238,9 +237,6 @@ <h2 class="h4 mt-4">Content not accessible</h2>
<h3 class="h6 mt-4">Non-compliances</h3>
<p>List of non-compliant WCAG criteria :</p>
<ul>
<li>
1.3.1 Info and Relationships, Level A
</li>
<li>
1.4.3 Contrast (Minimum), Level AA
</li>
Expand Down
Loading