-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#283] Add code example to show how to use token in tokens page of demo app #297
Open
Tayebsed93
wants to merge
23
commits into
develop
Choose a base branch
from
283-demoapp-add-code-example-to-show-how-to-use-token
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[#283] Add code example to show how to use token in tokens page of demo app #297
Tayebsed93
wants to merge
23
commits into
develop
from
283-demoapp-add-code-example-to-show-how-to-use-token
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Tayebsed93
force-pushed
the
283-demoapp-add-code-example-to-show-how-to-use-token
branch
from
November 21, 2024 09:31
d2655a6
to
7a22999
Compare
Tayebsed93
force-pushed
the
283-demoapp-add-code-example-to-show-how-to-use-token
branch
from
November 21, 2024 10:23
7a22999
to
880aaf5
Compare
Tayebsed93
changed the title
Token code example
Add code example to show how to use token
Nov 21, 2024
Tayebsed93
force-pushed
the
283-demoapp-add-code-example-to-show-how-to-use-token
branch
from
November 21, 2024 14:59
b79df14
to
19b5e5e
Compare
pylapp
previously approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pylapp
changed the title
Add code example to show how to use token
[#283] Add code example to show how to use token in tokens page of demo app
Nov 21, 2024
Tayebsed93
force-pushed
the
283-demoapp-add-code-example-to-show-how-to-use-token
branch
from
November 25, 2024 12:17
bdf7fc7
to
b048d5d
Compare
pylapp
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pylapp
added
the
⌛ Waiting for validations
The issue associated to this pull request is being reviewed by PO / a11y tea design team
label
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
⌛ Waiting for validations
The issue associated to this pull request is being reviewed by PO / a11y tea design team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
#283
Description
Add in view sections with code sample to explain to user show they can use the tokens
Motivation & Context
Make users able to learn how they can use the tokens, exactly like with ODS demo app
Types of change
Previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)