Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#279] Improve multiple based objects for tokenator values integration #301

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

pylapp
Copy link
Member

@pylapp pylapp commented Nov 21, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#279

Description

  • Split multiple* objects
  • Improve documentation
  • Enrich tests

Motivation & Context

Need to help integration of values generated by the tokenator, thus tokens it cannot manage must be moved elsewhere.

Types of change

  • Refactoring (non-breaking change)

Previews

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibiltiy review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
@pylapp pylapp linked an issue Nov 21, 2024 that may be closed by this pull request
15 tasks
@pylapp pylapp marked this pull request as draft November 21, 2024 12:13
@pylapp pylapp marked this pull request as ready for review November 21, 2024 12:15
@pylapp pylapp marked this pull request as draft November 21, 2024 12:27
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
@pylapp pylapp force-pushed the 279-tokens-improve-multiple-based-objects-for-tokenator-values-integration branch from 473c818 to b204754 Compare November 21, 2024 13:22
@pylapp pylapp marked this pull request as ready for review November 21, 2024 13:25
@pylapp
Copy link
Member Author

pylapp commented Nov 21, 2024

@ludovic35 Le message de commit peut être par exemple :

refactor: improve management of tokens for those based on color scheme or size classes (#279) (#301)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tokens] Improve Multiple-based objects for tokenator values integration
3 participants