Prepare for historical data #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AetherUnbound
force-pushed
the
bugfix/historical-data
branch
from
ca3bf6b
to
6fa9461
Compare
mpuckett159
approved these changes
May 23, 2021
| @@ -1,10 +1,10 @@ | |||
| {% for field in metadata.fields %} | |||
| {% set value = record.get(field.FieldName) %} | |||
| {% set value = record.get(field.FieldName) | string %} | |||
There was a problem hiding this comment.
Yea I was having trouble with the if not boolean so I just opted for this lol
| def _augment_with_salary(record: Record) -> str: | ||
| last = record["last_name"] | ||
| first = record["first_name"] | ||
| @lru_cache(maxsize=1000) |
There was a problem hiding this comment.
Glad we have this, it's slow as hell otherwise.
There was a problem hiding this comment.
Lol and it's a one line change too! After moving it out into something that's cached easily
This was referenced Jun 12, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two small changes to prepare for OrcaCollective/spd-lookup#23: