Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipes do not support comments #15385

Closed
deanmarcussen opened this issue Feb 21, 2024 · 1 comment · Fixed by #15386
Closed

Recipes do not support comments #15385

deanmarcussen opened this issue Feb 21, 2024 · 1 comment · Fixed by #15386
Milestone

Comments

@deanmarcussen
Copy link
Member

The recipe reader doesn't support comments in Json (it's a mode that isn't turned on).

Which is annoying when you have a lot of recipes, and need to make notes in them, as to why you did something.

Not sure if the System.Text pr has gone in yet, might change with that, as it's a Newtonsoft config that needs to be set.

@MikeAlhayek
Copy link
Member

MikeAlhayek commented Feb 21, 2024

Yes the STJ is already in main.

I did a brief look at the code. I think the reason why comments are not supported is because we parse using JOptions.Document which is not configured to allow comments. I think we need to change that to options that is derived from the Base options like 'Default' or create one a static instance for recipes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants