Support both Text & HTML in the same email

[hishamco]

/cc @MikeKry

[hishamco]

@Mike4tel could you please try to send via EmailTask all the 3 cases to ensure it was similar to the old behavior. Also, I might add unit tests too

[MikeKry]

@hishamco
Thanks for looking at this. Code looks good and I have tested all 3 scenarios.

Html - OK
Text - OK
"All" (may be renamed to multipart/alternative or something) - Works OK (as seen below). Just one more thing. There is need to have two Body fields - text and html (similar as it was before). Because you need to have different formatting in text and html.

[hishamco]

"All" (may be renamed to multipart/alternative or something)

All or Both make sense to me

There is need to have two Body fields - text and html (similar as it was before). Because you need to have different formatting in text and HTML.

This will revert the changes and let the body TextBody & HtmlBody

[hishamco]

@sebastienros are we fine to add two bodies into the MailMessage or shall we let the sender decide if the body is HTML or Text

One option if we use MailMessageFormat.All is to supply the HTML body and then stripe all the HTML tags to make it fine for the plain-text body. This way we can use a single body instead of two

[Mike4tel]

Just pointing out that only stripping html will not let users format text nicely for plain text.. it is needed for good marketing.

But I can see using stripped html version as another feature just to fight spam filters.

[MikeKry]

Is it possible to merge this one? :)

[hishamco]

We forgot this one :) I will do a final review and then merge

[MikeAlhayek]

@hishamco what is the problem that you are trying to solve? Why would we need All as an enum value?

Maybe we should have an interface for the message like INotificationMessage which we already have. Or something similar

public interface IEmailMessage 
{
    string Message { get; }
    bool IsHtml { get; }
}

[hishamco]

Maybe we should have an interface for the message like INotificationMessage which we already have. Or something similar

I don't think so, the issue was the email can be sent in both formats. In the past we already had IsHtml but it didn't fit anymore, that's why I introduced something similar to the MimiKit mail body

[github-actions]

This pull request has merge conflicts. Please resolve those before requesting a review.

[github-actions]

This pull request has merge conflicts. Please resolve those before requesting a review.

[hishamco]

@MikeKry could please do one more test, this PR takes so long, we need to review it and merge it ASAP

[gvkries]

There needs to be some kind of migration for existing email tasks. Currently, any existing email body is lost when I edit an existing mail task.

[gvkries]

This doesn't work for me either. Shouldn't this be like on('change,...)?
Additionally, I think the select element needs its own id.

[hishamco]

Let me check

[hishamco]

There needs to be some kind of migration for existing email tasks. Currently, any existing email body is lost when I edit an existing mail task.

I might not work extensively on workflow, I'm not sure how we can achieve that, feel free to add a commit in the PR

[gvkries]

There are still many issues at the moment in this PR. E.g. the UI is broken in the workflow editor, because the state of the selected body types is not restored. Also the code mirror editors are not working correctly, if they are initialized on a hidden input field.

[gvkries]

I think this is much simpler and better now.

But I still have the issue with the workflow task editor, where switching between HTML and Text only is not working correctly. I suggest that we just show both editors all the time and skip having to select between text/html/all.

[hishamco]

But I still have the issue with the workflow task editor, where switching between HTML and Text only is not working correctly. I suggest that we just show both editors all the time and skip having to select between text/html/all.

I will revise the workflow one more time

[sebastienros]

The workflow editor should provide two tabs or fields (with one collapsed by default?) for users to provide both values at all times. Either they provide 0, 1 or 2 contents then we just flow these values to the BodyMessage. We can pass null in the html/text argument if the text is empty (but not whitespace).

[sebastienros]

The comments should say the values are optional (can be null). Maybe use the ? operator to be specific.

[hishamco]

The workflow editor should provide two tabs or fields (with one collapsed by default?) for users to provide both values at all times. Either they provide 0, 1 or 2 contents then we just flow these values to the BodyMessage. We can pass null in the html/text argument if the text is empty (but not whitespace).

The current implementation allows the user to either use HTML or Text or both

EmailTask.mp4

[hishamco]

@gvkries please check the above video

[gvkries]

@hishamco As said:

1. You don't restore the dropdown state when editing an existing task. It always selects text by default.
2. If you're editing an task where you had HTML selected before, the whole code mirror editor breaks down. I guess this happens because the editor gets initialized on a hidden input field, but I don't know:
   E.g. it doesn't show the HTML at all:
   
   After clicking into the editor, it shows up but is still broken: