Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary argument in ThrowIfNullOrEmpty #15272

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Remove unnecessary argument in ThrowIfNullOrEmpty #15272

merged 3 commits into from
Feb 7, 2024

Conversation

sebastienros
Copy link
Member

No description provided.

Skrypt
Skrypt approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@Skrypt Skrypt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I digged into code to find that one and I did not see any indication that it will display a message but I trust you. I did not take time to test it.

@hishamco
Copy link
Member

hishamco commented Feb 7, 2024

I digged into code to find that one and I did not see any indication that

You should see it now :)

@sebastienros
Copy link
Member Author

@Skrypt FYI https://source.dot.net/#System.Collections.Immutable/System/Collections/ThrowHelper.cs,12 see CallerArgumentExpressionAttribute ?

@sebastienros sebastienros merged commit c3abb47 into main Feb 7, 2024
5 checks passed
@sebastienros sebastienros deleted the sebros/throwarg branch February 7, 2024 20:12
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
Closed
urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
@sebastienros @hishamco @urbanit
Remove unnecessary argument in ThrowIfNullOrEmpty (OrchardCMS#15272)
de26a04 
Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skrypt Skrypt Skrypt approved these changes

@hishamco hishamco hishamco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebastienros @hishamco @Skrypt