Add cache busting parameter to media thumbnails and links in Media Library (Lombiq Technologies: OCORE-143) #15276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Scripts/media.js # src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Scripts/media.min.js
MikeAlhayek
requested changes
Feb 22, 2024
src/OrchardCore.Modules/OrchardCore.Media/Controllers/AdminController.cs
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Media/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Media/Controllers/AdminController.cs
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Media/Controllers/AdminController.cs
Show resolved
Hide resolved
hishamco
requested changes
Feb 22, 2024
| @@ -30,6 +32,8 @@ public class AdminController : Controller | |||
| private readonly MediaOptions _mediaOptions; | |||
| private readonly IUserAssetFolderNameProvider _userAssetFolderNameProvider; | |||
| private readonly IChunkFileUploadService _chunkFileUploadService; | |||
| private readonly IFileVersionProvider _fileVersionProvider; | |||
| private readonly IServiceProvider _serviceProvider; | |||
There was a problem hiding this comment.
Suggested change
| private readonly IServiceProvider _serviceProvider; | |
| private readonly IMediaFileStoreCache _mediaFileStoreCache; |
| ) | ||
| IChunkFileUploadService chunkFileUploadService, | ||
| IFileVersionProvider fileVersionProvider, | ||
| IServiceProvider serviceProvider) |
There was a problem hiding this comment.
Suggested change
| IServiceProvider serviceProvider) | |
| IMediaFileStoreCache mediaFileStoreCache) |
| @@ -52,6 +57,8 @@ IChunkFileUploadService chunkFileUploadService | |||
| S = stringLocalizer; | |||
| _userAssetFolderNameProvider = userAssetFolderNameProvider; | |||
| _chunkFileUploadService = chunkFileUploadService; | |||
| _fileVersionProvider = fileVersionProvider; | |||
| _serviceProvider = serviceProvider; | |||
There was a problem hiding this comment.
Suggested change
| _serviceProvider = serviceProvider; | |
| _mediaFileStoreCache = mediaFileStoreCache; |
Comment on lines
+519
to
+520
| var mediaFileStoreCache = _serviceProvider.GetService<IMediaFileStoreCache>(); | ||
| if (mediaFileStoreCache == null) |
There was a problem hiding this comment.
Suggested change
| var mediaFileStoreCache = _serviceProvider.GetService<IMediaFileStoreCache>(); | |
| if (mediaFileStoreCache == null) | |
| if (_mediaFileStoreCache == null) |
src/OrchardCore.Modules/OrchardCore.Media/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
MikeAlhayek
approved these changes
Feb 23, 2024
urbanit
pushed a commit
to urbanit/OrchardCore
that referenced
this pull request
Mar 18, 2024
…brary (OrchardCMS#15276) Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15273.
Fixes #3925.