Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete CustomSettingsService methods #15280

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented Feb 8, 2024

No description provided.

@MikeAlhayek
Copy link
Member

I think we marked these methods are obsolete in the previous release. I think these obsolete methods should be removed as part of the next major release. Just to reduce the amount of breaking change when people upgrade from like 1.6 to 1.8

@hishamco hishamco merged commit a1d6931 into main Feb 15, 2024
5 checks passed
@hishamco hishamco deleted the hishamco/obsolete-custom-settings branch February 15, 2024 19:34
urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants