Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS settings fix #15318

Merged
merged 1 commit into from
Feb 13, 2024
Merged

CORS settings fix #15318

merged 1 commit into from
Feb 13, 2024

Conversation

lampersky
Copy link
Contributor

fixes #15259

/cc: @giannik

image

@MikeAlhayek MikeAlhayek merged commit 6b7d4e3 into OrchardCMS:main Feb 13, 2024
4 checks passed
@sebastienros
Copy link
Member

Were the files generated by gulp or fixed by hand? Some variables have the wrong casing and another PR updating Bootstrap is showing that (it's using gulp correctly there)

https://github.com/OrchardCMS/OrchardCore/pull/15374/files

@sebastienros
Copy link
Member

See this source file for OriginalName and originalName casings: https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.Cors/Assets/Admin/cors-admin.js#L73-L76

This should be fixed, and then gulp run again to update the generated sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with CORS Policy renderings in admin
3 participants