Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IHttpClientFactory.CreateClient() instead of static HttpClient #15350

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Use IHttpClientFactory.CreateClient() instead of static HttpClient #15350

merged 3 commits into from
Feb 16, 2024

Conversation

hishamco
Copy link
Member

Fixes #15346

@hishamco hishamco removed the request for review from sfmskywalker February 16, 2024 17:13
@hishamco
Copy link
Member Author

I will check the unit tests seems something broken due the injection

@hishamco hishamco merged commit 7c65a42 into main Feb 16, 2024
5 checks passed
@hishamco hishamco deleted the hishamco/http-client branch February 16, 2024 17:56
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
Closed
urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
@hishamco @urbanit
Use IHttpClientFactory.CreateClient() instead of static HttpClient (O…
44bbaef 
…rchardCMS#15350)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeAlhayek MikeAlhayek MikeAlhayek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use IHttpClientFactory in MediaStep to create instance of HttpClient
2 participants
@hishamco @MikeAlhayek