Allow binding RememberMe settings during login #15429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it's a best practice. all the login form data should be filled by the user |
|
Why not? There is no difference between this and any form. In this case, we just allow other scenarios to carry the remember me from previous state |
|
If we agree on this, someone will come after a while, then will ask to pass the username too :) |
|
I agree with @hishamco on this one. It should be a user action, else you can also create a custom login razor view that will do this too. But normally, we shouldn't. |
|
Can we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we redirect the user to the login page, it is helpful to pass the "Remember Me" settings in the URL.