Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused logger from UserDisplayDriver #17131

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
using Microsoft.AspNetCore.Identity;
using Microsoft.AspNetCore.Mvc.Localization;
using Microsoft.Extensions.Localization;
using Microsoft.Extensions.Logging;
using OrchardCore.DisplayManagement.Handlers;
using OrchardCore.DisplayManagement.Notify;
using OrchardCore.DisplayManagement.Views;
Expand All @@ -23,7 +22,6 @@
private readonly INotifier _notifier;
private readonly IAuthorizationService _authorizationService;
private readonly IEnumerable<IUserEventHandler> _userEventHandlers;
private readonly ILogger _logger;

internal readonly IHtmlLocalizer H;
internal readonly IStringLocalizer S;
Expand All @@ -32,7 +30,6 @@
UserManager<IUser> userManager,
IHttpContextAccessor httpContextAccessor,
INotifier notifier,
ILogger<UserDisplayDriver> logger,
IEnumerable<IUserEventHandler> userEventHandlers,
IAuthorizationService authorizationService,
IHtmlLocalizer<UserDisplayDriver> htmlLocalizer,
Expand All @@ -42,7 +39,6 @@
_httpContextAccessor = httpContextAccessor;
_notifier = notifier;
_authorizationService = authorizationService;
_logger = logger;
_userEventHandlers = userEventHandlers;
H = htmlLocalizer;
S = stringLocalizer;
Expand Down Expand Up @@ -126,7 +122,7 @@
var userContext = new UserContext(user);
// TODO This handler should be invoked through the create or update methods.
// otherwise it will not be invoked when a workflow, or other operation, changes this value.
await _userEventHandlers.InvokeAsync((handler, context) => handler.DisabledAsync(context), userContext, _logger);

Check failure on line 125 in src/OrchardCore.Modules/OrchardCore.Users/Drivers/UserDisplayDriver.cs

View workflow job for this annotation

GitHub Actions / Build & Test (ubuntu-latest)

The name '_logger' does not exist in the current context

Check failure on line 125 in src/OrchardCore.Modules/OrchardCore.Users/Drivers/UserDisplayDriver.cs

View workflow job for this annotation

GitHub Actions / Build & Test (ubuntu-latest)

The name '_logger' does not exist in the current context

Check failure on line 125 in src/OrchardCore.Modules/OrchardCore.Users/Drivers/UserDisplayDriver.cs

View workflow job for this annotation

GitHub Actions / Build & Test (ubuntu-latest)

The name '_logger' does not exist in the current context

Check failure on line 125 in src/OrchardCore.Modules/OrchardCore.Users/Drivers/UserDisplayDriver.cs

View workflow job for this annotation

GitHub Actions / Build & Test (ubuntu-latest)

The name '_logger' does not exist in the current context

Check failure on line 125 in src/OrchardCore.Modules/OrchardCore.Users/Drivers/UserDisplayDriver.cs

View workflow job for this annotation

GitHub Actions / Build & Test (windows-latest)

The name '_logger' does not exist in the current context

Check failure on line 125 in src/OrchardCore.Modules/OrchardCore.Users/Drivers/UserDisplayDriver.cs

View workflow job for this annotation

GitHub Actions / Build & Test (windows-latest)

The name '_logger' does not exist in the current context

Check failure on line 125 in src/OrchardCore.Modules/OrchardCore.Users/Drivers/UserDisplayDriver.cs

View workflow job for this annotation

GitHub Actions / Build & Test (windows-latest)

The name '_logger' does not exist in the current context

Check failure on line 125 in src/OrchardCore.Modules/OrchardCore.Users/Drivers/UserDisplayDriver.cs

View workflow job for this annotation

GitHub Actions / Build & Test (windows-latest)

The name '_logger' does not exist in the current context
}
}
else if (!isEditingDisabled && model.IsEnabled && !user.IsEnabled)
Expand All @@ -135,7 +131,7 @@
var userContext = new UserContext(user);
// TODO This handler should be invoked through the create or update methods.
// otherwise it will not be invoked when a workflow, or other operation, changes this value.
await _userEventHandlers.InvokeAsync((handler, context) => handler.EnabledAsync(context), userContext, _logger);

Check failure on line 134 in src/OrchardCore.Modules/OrchardCore.Users/Drivers/UserDisplayDriver.cs

View workflow job for this annotation

GitHub Actions / Build & Test (ubuntu-latest)

The name '_logger' does not exist in the current context

Check failure on line 134 in src/OrchardCore.Modules/OrchardCore.Users/Drivers/UserDisplayDriver.cs

View workflow job for this annotation

GitHub Actions / Build & Test (ubuntu-latest)

The name '_logger' does not exist in the current context

Check failure on line 134 in src/OrchardCore.Modules/OrchardCore.Users/Drivers/UserDisplayDriver.cs

View workflow job for this annotation

GitHub Actions / Build & Test (ubuntu-latest)

The name '_logger' does not exist in the current context

Check failure on line 134 in src/OrchardCore.Modules/OrchardCore.Users/Drivers/UserDisplayDriver.cs

View workflow job for this annotation

GitHub Actions / Build & Test (ubuntu-latest)

The name '_logger' does not exist in the current context

Check failure on line 134 in src/OrchardCore.Modules/OrchardCore.Users/Drivers/UserDisplayDriver.cs

View workflow job for this annotation

GitHub Actions / Build & Test (windows-latest)

The name '_logger' does not exist in the current context

Check failure on line 134 in src/OrchardCore.Modules/OrchardCore.Users/Drivers/UserDisplayDriver.cs

View workflow job for this annotation

GitHub Actions / Build & Test (windows-latest)

The name '_logger' does not exist in the current context

Check failure on line 134 in src/OrchardCore.Modules/OrchardCore.Users/Drivers/UserDisplayDriver.cs

View workflow job for this annotation

GitHub Actions / Build & Test (windows-latest)

The name '_logger' does not exist in the current context

Check failure on line 134 in src/OrchardCore.Modules/OrchardCore.Users/Drivers/UserDisplayDriver.cs

View workflow job for this annotation

GitHub Actions / Build & Test (windows-latest)

The name '_logger' does not exist in the current context
}

if (context.Updater.ModelState.IsValid)
Expand Down
Loading