fix(dialogHeight): Adapt dialog height to images with large height #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt dialog height to images with a big ratio, when its height it's much bigger than the width; This corrects the problem with some iPhone devices where the height of the dialog surpasses the height of the device's screen.
Adapt dialog height to images with big ration by height; Adaptable to every iPhone with different screen sizes and ratios.
houndci-bot
reviewed
Apr 17, 2021
| var width = bounds.size.width | ||
|
|
||
| let imageHeight = image.size.height | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| let width = bounds.size.width | ||
| let ratio = image.size.height / image.size.width | ||
| var width = bounds.size.width | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| @@ -34,11 +34,28 @@ internal extension UIImageView { | |||
| - returns: Height to set on the imageView | |||
| */ | |||
| func pv_heightForImageView() -> CGFloat { | |||
|
|
|||
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt dialog height to images with a big ratio, when its height it's much bigger than the width;
Adaptable to every iPhone with different screen sizes and ratios;
This corrects the problem with some iPhone devices where the height of the dialog surpasses the height of the device's screen;
Tested in every iPhone since 6s and SE 1st generation.