OriginTrail Devnet Prerelease v6.2.0 Hotfix 3 #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OriginTrail v6.2.0 Devnet Release
Added pull sharding table migration Removed blob calculation from operational db migration
djordjekovac
requested review from
branarakic,
NZT48 and
0xbraindevd
as code owners
djordjekovac
changed the title
NZT48
reviewed
Jan 31, 2024
NZT48
changed the title
Mihajlo-Pavlovic
approved these changes
Jan 31, 2024
0xbraindevd
requested changes
Jan 31, 2024
| @@ -1294,6 +1294,7 @@ class Web3Service { | |||
| this.scoringFunctionsContracts[2], | |||
| 'getParameters', | |||
| [], | |||
| CONTRACTS.LINEAR_SUM, | |||
There was a problem hiding this comment.
This won't work, we're not listening to events of this contract. Also getter getParameters returns multiple values, while setters are separate for each parameter, so cache should be cleared on change of any of the parameters, same goes for Log2PLDSF parameters caching
Fixed LinearSum score calculation to avoid underflows
NZT48
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.