add overflow warnings to linear sum, fix max distance calculation #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroxbt
requested review from
branarakic,
djordjekovac,
NZT48 and
0xbraindevd
as code owners
NZT48
approved these changes
Feb 14, 2024
|
Good catch, thanks @zeroxbt! |
Mihajlo-Pavlovic
approved these changes
Feb 14, 2024
This was referenced Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added warnings in case distance and stake are greater than uint64, as this should never happen, but currently there is no way to notice if it does.
I've fixed the max distance calculation, as it calculates the distance between the nodes at the edges instead of finding the max distance of the neighborhood.