Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): reslove webgpu errors #170

Merged
merged 4 commits into from
May 23, 2023
Merged

fix(android): reslove webgpu errors #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1f9767
docs: add contributing guide
lslzl3000 May 9, 2023
69599df
Merge branch 'Orillusion:main' into main
lslzl3000 May 12, 2023
2d709f0
fix(android): reslove webgpu errors
lslzl3000 May 20, 2023
ca14ebe
docs: update readme
lslzl3000 May 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/bug_report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ If applicable, add screenshots to help explain your problem
## Orillusion engine version
State the version you use for developement, e.g. 0.5.0

## Desktop (please complete the following information)
## Platform (please complete the following information)
- OS: [e.g. win, mac, android]
- Browser [e.g. chrome]
- Version [e.g. 113]
- Browser: [e.g. chrome]
- Version: [e.g. 113]

## Code demo link
If applicabla, please provide a sandbox/codepen/code snippet... to demonstrate the bug
Expand Down
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/bug_report_zh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ assignees: ''

## 本机系统 (请填写完整):
- OS: [e.g. win, mac, android]
- Browser [e.g. chrome]
- Version [e.g. 113]
- Browser: [e.g. chrome]
- Version: [e.g. 113]

## Codepen链接
如果有sandbox/codepen的代码示例链接，请提供
Expand Down
9 changes: 7 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,13 @@ await Engine3D.init({
Please read the [Docs](https://www.orillusion.com/guide/) to Learn More.

## Platform
**Chrome Desktop: 113+**
**Edge Desktop: 113+**
**Windows/Mac/Linux:**
- Chrome 113+
- Edge: 113+

**Android (Behind the `enable-unsafe-webgpu` flag):**
- Chrome Canary 113+
- Edge Canary 113+

## Useful links
- [Official Web Site](https://www.orillusion.com/)
Expand Down
2 changes: 1 addition & 1 deletion src/gfx/graphics/webGpu/Context3D.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class Context3D {
}

this.device = await this.adapter.requestDevice({
requiredFeatures: [`texture-compression-bc`],
//requiredFeatures: [`texture-compression-bc`],
requiredLimits: {
minUniformBufferOffsetAlignment: 256,
maxStorageBufferBindingSize: this.adapter.limits.maxStorageBufferBindingSize
Expand Down
2 changes: 1 addition & 1 deletion src/gfx/graphics/webGpu/descriptor/WebGPUDescriptorCreator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export class WebGPUDescriptorCreator {
// if(!rps.customSize){
rps.outAttachments = [
{
format: GPUTextureFormat.bgra8unorm,
format: webGPUContext.presentationFormat,
},
];
// }
Expand Down