Update BDDRunner.cfc #150
Merged
Update BDDRunner.cfc #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
variable thisSuite isn't defined if the for loop is never reached.
lmajano
reviewed
Aug 11, 2023
system/runners/BDDRunner.cfc
Outdated
| @@ -153,7 +153,7 @@ component | |||
| e, | |||
| arguments.target, | |||
| arguments.testResults, | |||
| thisSuite | |||
| thisSuite?:"" | |||
There was a problem hiding this comment.
Can you change it to a ternary, there are still many issues with Adobe engines and elvis.
isNull( thisSuite ) ? {} : thisSuite
Changed to ternary operation per Luis.
|
Updated change to ternary per Luis. |
|
hmm, why did you close it? @lhoess |
|
Because I'm not sure what I'm doing ;-) and couldn't see how to submit my new changes to the request. |
|
You did great!!! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The variable thisSuite isn't defined if the for loop in the try/catch is never reached before the error.
Found this would occur when the model threw an error.
Please note that all PRs must have tests attached to them
IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.
Jira Issues
All PRs must have an accompanied Jira issue. Please make sure you created it and linked it here.
Type of change
Checklist